Re: [PATCH] m4: replace AC_DIAGNOSE with m4_warn

[Karl Berry]

--- a/m4/obsolete.m4
+++ b/m4/obsolete.m4

Pushed, thanks.

grep -r shows more occurrences of AC_DIAGNOSE in m4/init.m4 (seems
straightforward) and mkdirp.m4, which seems to be a decision that was
undone, but I don't have the energy to try to find the discussion now to
see how to "adjust [the] warning message".  Maybe you could take a look
when you have a chance? --thanks, karl.

Re: [PATCH] m4: replace AC_DIAGNOSE with m4_warn

[Jim Meyering]

On Sat, Dec 11, 2021 at 10:07 PM Mike Frysinger  wrote:
> AC_DIAGNOSE was marked obsolete with autoconf-2.62 in 2008.
>
> * m4/obsolete.m4: Change AC_DIAGNOSE to m4_warn.
> ---
>  m4/obsolete.m4 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/m4/obsolete.m4 b/m4/obsolete.m4
> index 79f3b234bfc5..bf3b68271673 100644
> --- a/m4/obsolete.m4

Looks fine. Thanks!

[PATCH] m4: replace AC_DIAGNOSE with m4_warn

[Mike Frysinger]

AC_DIAGNOSE was marked obsolete with autoconf-2.62 in 2008.

* m4/obsolete.m4: Change AC_DIAGNOSE to m4_warn.
---
 m4/obsolete.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/obsolete.m4 b/m4/obsolete.m4
index 79f3b234bfc5..bf3b68271673 100644
--- a/m4/obsolete.m4
+++ b/m4/obsolete.m4
@@ -9,7 +9,7 @@
 # with or without modifications, as long as this notice is preserved.
 
 AC_DEFUN([AM_CONFIG_HEADER],
-[AC_DIAGNOSE([obsolete],
+[m4_warn([obsolete],
 ['$0': this macro is obsolete.
 You should use the 'AC][_CONFIG_HEADERS' macro instead.])dnl
 AC_CONFIG_HEADERS($@)])
@@ -17,7 +17,7 @@ AC_CONFIG_HEADERS($@)])
 AC_DEFUN([AM_PROG_CC_STDC],
 [AC_PROG_CC
 am_cv_prog_cc_stdc=$ac_cv_prog_cc_stdc
-AC_DIAGNOSE([obsolete],
+m4_warn([obsolete],
 ['$0': this macro is obsolete.
 You should simply use the 'AC][_PROG_CC' macro instead.
 Also, your code should no longer depend upon 'am_cv_prog_cc_stdc',
-- 
2.33.0