Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 11:29, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > > On 18 Jan 2022 09:48, Jim Meyering wrote: > ... > > > But IMHO that's too much duplication/syntax. > > > How about this instead? > > > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;;

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > On 18 Jan 2022 09:48, Jim Meyering wrote: ... > > But IMHO that's too much duplication/syntax. > > How about this instead? > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;; esac > > looks reasonable for POSIX shell. not a fan

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 09:48, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > > From: Thomas Deutschmann > > > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > > tests, do not require .pyo files (for python3)") had a slight logic > > error in that it

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Jim Meyering
On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > From: Thomas Deutschmann > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > tests, do not require .pyo files (for python3)") had a slight logic > error in that it missed a `test` call. > > Reported to Gentoo at

[PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-17 Thread Mike Frysinger
From: Thomas Deutschmann Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python tests, do not require .pyo files (for python3)") had a slight logic error in that it missed a `test` call. Reported to Gentoo at https://bugs.gentoo.org/715040. * t/py-compile-basedir.sh: Add test