Re: [PATCH] Testsuite: do not use `chmod -R' when cleaning up.

2009-10-06 Thread Stefano Lattarini
(IMHO). Regards, Stefano From 73fb9764019046d3d2dbd40dc711c8c8a0293b27 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue, 6 Oct 2009 17:01:23 +0200 Subject: [PATCH] Testsuite: do not use `chmod -R' when cleaning up. * tests/Makefile.am (clean-local-check): Do

[PATCH] Avoid leaking TEST_LOG_COMPILER in environment of test scripts

2009-10-09 Thread Stefano Lattarini
TEST_LOG_COMPILER=/bin/ksh', which can be used to check that the test scripts are portable to ksh). The just-one-line attached patch fixes this. Regards, Stefano From 5ebb0024e03afaa6df86132039a2369de3c099f8 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 8

[PATCH] Updating code enabling Bourne-compatibility in test scripts

2009-10-09 Thread Stefano Lattarini
. The simple attached patch should do this. Regards, Stefano From b4f072009196c88571daccec7f79efe477b69c51 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 8 Oct 2009 22:57:26 +0200 Subject: [PATCH] Updated code enabling Bourne-compatibility in test cases

Re: [PATCH] Updating code enabling Bourne-compatibility in test scripts

2009-10-09 Thread Stefano Lattarini
At Friday 09 October 2009, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Fri, Oct 09, 2009 at 05:37:29PM CEST: The code snippet enabling Bourne-compatibility has been improved in autoconf since the 2.59c version, which was the version from which tests/defs.in

Re: testsuite failures when test scripts are run with zsh

2009-10-10 Thread Stefano Lattarini
At Saturday 10 October 2009, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Sat, Oct 10, 2009 at 03:42:52AM CEST: [CUT] Hmm, I see a few inconsistencies cropping up here. First, we already have AUTOMAKE_run. It has slightly different syntax. With your

testsuite: fixed spurious failure in vala4.test (w.r.t. Solaris sh)

2009-10-11 Thread Stefano Lattarini
not found. exit_status=1 + set +e + cd /home/stefano/src/automake/tests + test 0 != 0 + echo vala4: exit 1 vala4: exit 1 + exit 1 From 3ce5267ee2794c00f71e74906065b4d113acb43b Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 11 Oct 2009 13:37:28 +0200

Re: testsuite: fixed spurious failure in vala4.test (w.r.t. Solaris sh)

2009-10-11 Thread Stefano Lattarini
At Sunday 11 October 2009, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Thanks for looking into this. I prefer not to paper over any bugs that we don't understand, though. This is surely a good policy. I sent the patch only because I easily came up with it (by five minutes of

Re: testsuite failures when test scripts are run with zsh

2009-10-13 Thread Stefano Lattarini
/defs.in', to make it re-execute the test scripts with CONFIG_SHELL. But this should be obviously done in a distinct patch. Regards, Stefano From 4da7f4d6926f3001366be8e71b5288877ef34d73 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 11 Oct 2009 14:49

Re: testsuite failures when test scripts are run with zsh

2009-10-23 Thread Stefano Lattarini
Stefano Lattarini stefano.lattar...@gmail.com wrote: Hi Ralf. A new version of the patch is attached. It's still not definitive, but I hope most things are settled by now. And, of course, they're not. Sigh. With FreeBSD-7.2 /bin/sh, the construct: if eval $run_evald_cmd

Re: testsuite failures when test scripts are run with zsh

2009-10-28 Thread Stefano Lattarini
: silent8.test (exit: 1) FAIL: subpkg.test (exit: 1) FAIL: txinfo21.test (exit: 1) Regards, Stefano From 4c66b1f7e060271f4dff63ace3b49e4c3bc3cdf3 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 23 Oct 2009 18:27:55 +0200 Subject: [PATCH] Testsuite: avoid

Re: [PATCH] Testsuite: defs.in: work around zsh incompatibility w.r.t handling `$0'

2009-11-10 Thread Stefano Lattarini
so. Moreover, the previous patch had some typos and bad wordings, so I took the opportunity and fixed them too. The updated patch is attached, Regards, Stefano From 3ca07159b6215845797dda1aff3a7c1225ecdb26 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue

Re: testsuite failures when test scripts are run with zsh

2009-11-12 Thread Stefano Lattarini
Aaargh! There is a bug (another), with heirloom-sh this time. Apparently, shell traces are not enabled/disabled in run_command() the way they should. Please do not apply the patch until I'll had figured out and fixed the problem (I've no time right now, maybe tomorrow I can do something).

Re: testsuite failures when test scripts are run with zsh

2009-11-13 Thread Stefano Lattarini
Stefano Lattarini wrote: Aaargh! There is a bug (another), with heirloom-sh this time. Apparently, shell traces are not enabled/disabled in run_command() the way they should. Please do not apply the patch until I'll had figured out and fixed the problem (I've no time right now, maybe

Re: testsuite: fixed spurious failure in vala4.test (w.r.t. Solaris sh)

2009-12-04 Thread Stefano Lattarini
At Sunday 11 October 2009, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Sun, Oct 11, 2009 at 05:49:20PM CEST: While trying to run the automake test scripts with the Heirloom sh (http://heirloom.sourceforge.net/sh.html, which should be quite similar

[PATCHES] Remove useless executable bits from two files

2009-12-04 Thread Stefano Lattarini
simple attached patches correct these glitches. This is admittedly nitpicking, but I think that the fewer warts the better. I hope you'll agree with me. Regards, Stefano From a5393aff1a019ab270b2096a12c2ac0cdd66872e Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date

Re: testsuite failures when test scripts are run with zsh

2009-12-05 Thread Stefano Lattarini
2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 5 Dec 2009 15:03:54 +0100 Subject: [PATCH] Testsuite: avoid Zsh-related problem with `set -x'. * tests/README: Describe Zsh 4.x `set -x' a.k.a. `xtrace' issue and workaround with run_command. * tests/defs.in (run_command): New

[PATCH 2/3] maintainer-check: warn against zsh xtrace bug

2009-12-09 Thread Stefano Lattarini
. (syntax_check_rules): Added `sc_tests_stderr_redirection'. From a6f89c12687e430094f47c3375ea9b72f159a409 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue, 8 Dec 2009 18:09:14 +0100 Subject: [PATCH 2/3] maintainer-check: warn against zsh xtrace bug Extended

[PATCH 1/4] maintainer-check: check consistency of list of test scripts.

2009-12-11 Thread Stefano Lattarini
that maintainer-check fails after applying this patch, as some test scripts are missing from $(TESTS). This will be fixed by the next patch. From 0a80b604e09f033d5f7e84d7fbebf9bfb683935c Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 11 Dec 2009 00:26:32

[PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test.

2009-12-11 Thread Stefano Lattarini
and in the tested sematic). From 9a5b137e2903dc6cefa03949d6fd6545c9e129cb Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 11 Dec 2009 13:30:40 +0100 Subject: [PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test. * tests/acoutbs: Enable `errexit' shell flag

Re: [PATCH 3/4] Fix test acoutbs2.test

2009-12-11 Thread Stefano Lattarini
9e7afc18064799a2257ca6ec8f229a24a0e08c98 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 11 Dec 2009 13:17:40 +0100 Subject: [PATCH 3/4] Fix test acoutbs2.test. * tests/acoutbs2: In the generated configure.in: add proper calls to AC_INIT and AM_INIT_AUTOMAKE, and remove explicit

Testsuite: workaround for ksh bug w.r.t. `${1+$@}'

2009-12-13 Thread Stefano Lattarini
Hello automakers. While doing more tests on my patch series about zsh xtraces incompatibilities, I run into a subtle bug of ksh. This bug is related to a mishandling of the `${1+$@}' expression (occurring when exactly one empty argument is given), and it breaks the test script `automake.test'.

[PATCH] Testsuite: fix spurious failure of instspc.test w.r.t. ATT Ksh.

2009-12-17 Thread Stefano Lattarini
: ./a:: [No such file or directory] + echo KO KO -*-*- Well, the description of the bug was convoluted, but at least the patch to fix it is very simple, and is attached. Regards, Stefano From 53c9c8d387e4f7f8cbac749bc0e30cbd7e8ba636 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar

Re: [PATCH 0/4] Testsuite: check the list of test scripts

2009-12-25 Thread Stefano Lattarini
At Friday 11 December 2009, Stefano Lattarini stefano.lattar...@gmail.com wrote: Hello automakers. While exploring and editing the automake testsuite, I came across three test scripts (acoutbs2.test, badopt.test, extra2.test) which were not listed in the $(TESTS) variable, and thus were

[PATCH 0/6] Testsuite: check the list of test scripts

2009-12-25 Thread Stefano Lattarini
Hello automakers. This patch series is an amendment of my previously posted series on the same issue -- see: http://lists.gnu.org/archive/html/automake-patches/2009-12/msg00026.html Since all the patches posted previously have been amended, I've decided to re-propose the series in this fresh

[PATCH 1/6] Maint-check: check consistency of list of test scripts.

2009-12-25 Thread Stefano Lattarini
that maintainer-check fails after applying this patch, as some test scripts are missing from $(TESTS). This will be fixed by the next patch. From 45f9809c052f3237b6f346e1f4c5dd82572b4be8 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 25 Dec 2009 23:17:07

[PATCH 3/6] Fix test acoutbs2.test.

2009-12-25 Thread Stefano Lattarini
This patch fixes some bugs in the test script acoutbs2.test (missing AM_INIT_AUTOMAKE and AC_INIT, missing call to $ACLOCAL), which prevented it from working. From 9566f9fba3b50d5fecf4142468d80379718bc368 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 25

[PATCH 4/6] Slighty improve tests acoutbs.test and acoutbs2.test.

2009-12-25 Thread Stefano Lattarini
and in the tested sematic). From 514d3c148a06adfbfdcfa5a66ea7bd1bb68621cc Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 25 Dec 2009 23:21:25 +0100 Subject: [PATCH 4/6] Slighty improve tests acoutbs.test and acoutbs2.test. * tests/acoutbs2.test: Enable `errexit' shell

[PATCH 5/6] maint-check: refactoring to avoid code duplication

2009-12-25 Thread Stefano Lattarini
: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 26 Dec 2009 00:47:02 +0100 Subject: [PATCH 5/6] maint-check: refactoring to avoid code duplication The recent extension of the `maintainer-check' target (to include checks on the consistency of the list of test scripts) has introduced some

Re: [PATCH] Testsuite: defs.in: work around zsh incompatibility w.r.t handling `$0'

2009-12-25 Thread Stefano Lattarini
Ping? (In the meantime, I rebased the patch against the latest master branch). Regards, Stefano From: Stefano Lattarini stefano.lattar...@gmail.com Date: 2009-12-26 02:08:36 2009 +0100 Subject: [PATCH] Work around Zsh incompatibility w.r.t handling `$0' (testsuite related) * tests/README

Re: [PATCH 2/6] Add forgotten test scripts to $(TESTS).

2010-01-18 Thread Stefano Lattarini
At Sunday 17 January 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hi Stefano, I've applied your patches 2/6, 3/6, and 4/6 of this series to maint, and merged to master and branch-1.11. Thanks. Do you plan to apply the other patches of the series too? In that case, I could do a

Re: copyright statement

2010-01-29 Thread Stefano Lattarini
At Friday 29 January 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Fri, Jan 29, 2010 at 11:17:05PM CET: I'm rebasing one of my patch series for Automake, written still in 2009, and I find it quite annoying (and error-prone) to have to re-edit otherwise

[PATCH 0/3] Testsuite: check the list of test script

2010-01-29 Thread Stefano Lattarini
Hello automakers. In this thread, I'll post an amended/updated version of a previous patch series of mine, which introduced a maintainer-specific check about the consistency of the list of tests in the Automake testsuite. The previous patch series has been already partially applied, so I found

[PATCH 1/3] Maint-check: check consistency of list of test scripts.

2010-01-29 Thread Stefano Lattarini
fc94f686ad128c468430675314a5af29df8baf8d Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 30 Jan 2010 01:23:44 +0100 Subject: [PATCH 1/3] Maint-check: check consistency of list of test scripts. * Makefile.am (maintainer-check-list-of-tests): New target

[PATCH 2/3] Maint-check: refactoring to avoid code duplication

2010-01-29 Thread Stefano Lattarini
The previous patch introduced some code duplication. This patch takes care of removing (part of) such duplication, by adding a new *.am makefile fragment to be included by the relevant Makefiles.am From 6dc1a373b889e484d979ce7a1107ec9a26a2ee0e Mon Sep 17 00:00:00 2001 From: Stefano Lattarini

[PATCH 3/3] Some more refactoring in makefiles, to avoid code duplication.

2010-01-29 Thread Stefano Lattarini
2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 30 Jan 2010 02:35:35 +0100 Subject: [PATCH 3/3] Refactoring in makefiles, to avoid code duplication. * Makefile.am (recurse_in_subdirs_cmd): New variable, factor out non-obvious shell code common to some rules (with a small fix

[PATCH 0/8] Towards a Zsh-compatible Automake testsuite

2010-02-01 Thread Stefano Lattarini
*** INTRODUCTION *** This is a reproposal of an older patch series aimed at making the Automake testsuite fully compatible with Zsh (both versions 3 and 4). The main problem that is tackled by these patches is the peculiar way Zsh handles stderr redirections with the `xtrace' a.k.a. `set -x'

[PATCH 1/8] Testsuite: avoid Zsh-related problem with `set -x'

2010-02-01 Thread Stefano Lattarini
Testsuite: avoid Zsh-related problem with `set -x'. * tests/README: Describe Zsh 4.x `set -x' a.k.a. `xtrace' issue and workaround with run_command. * tests/defs.in: Updated copyright years. (run_command): New function, to be used for commands whose stderr and/or stdout need to be captured.

[PATCH 2/8] Maintainer-check: warn against zsh xtrace bug

2010-02-01 Thread Stefano Lattarini
. (sc_tests_stderr_redirection__whitelist): Likewise. (syntax_check_rules): Added `sc_tests_stderr_redirection'. From ec8b0ea72f2423d648e366d76ac192c7307e1411 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue, 8 Dec 2009 18:09:14 +0100 Subject: [PATCH 2/8] Maintainer

[PATCH 4/8] Work around a bug of ATT Ksh w.r.t. ${1+$@}

2010-02-01 Thread Stefano Lattarini
Work around a bug of ATT Ksh w.r.t. ${1+$@} * tests/defs.in (run_command): Don't use the expression `${1+$@}', as it might trigger a bug of ATT Korn shell. From 8d9e6fa0eb0a1ab74a0bb200fcbf3da2c940b256 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 13 Dec

[PATCH 5/8] Improve description of `run_command' in README

2010-02-01 Thread Stefano Lattarini
information. From 1637c448ad4c315f4fba501d46a568ceca3f2da8 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 29 Jan 2010 15:22:11 +0100 Subject: [PATCH 5/8] Improve description of `run_command' in README * tests/README: Improve and extend the existing

[PATCH 7/8] Testsuite: run_command can now set env variables

2010-02-01 Thread Stefano Lattarini
: Likewise. * tests/suffix12.test: Likewise. * tests/suffix8.test: Likewise. From 7b600ff8bea4e0fd7f075b61ef06f22b456cf190 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 30 Jan 2010 19:18:18 +0100 Subject: [PATCH 7/8] Testsuite: run_command can now set env

[PATCH] Add tests about support of wildcards in EXTRA_DIST

2010-02-20 Thread Stefano Lattarini
5f22886459c360e43ecd762efb058c53c0691bbb Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 20 Feb 2010 16:41:56 +0100 Subject: [PATCH] Add tests about support of wildcards in EXTRA_DIST. * tests/extra10.test: New test, check basic support of wildcards in EXTRA_DIST. * tests/extra11

Re: [PATCH] Add tests about support of wildcards in EXTRA_DIST

2010-02-20 Thread Stefano Lattarini
At Saturday 20 February 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hi Stefano, * Stefano Lattarini wrote on Sat, Feb 20, 2010 at 04:49:37PM CET: I've written a small patch adding some tests. Note that they are mostly tentative, and might also be inclomplete, since I have

Re: [PATCH] Add tests about support of wildcards in EXTRA_DIST

2010-03-03 Thread Stefano Lattarini
the same error, but it can't be fixed without editing the git repository, which IIRC is a big no-no for published repos). Again, my apologies for the mistake, Stefano From 298876462fbfec7e8d6dfea035da3c10071a927c Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date

[BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-03-07 Thread Stefano Lattarini
From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 7 Mar 2010 15:48:10 +0100 Subject: [PATCH] Generated tests are now just a thin layer around other tests. * tests/Makefile.am: Rewrite the rule to generate the `*-p.test' test scripts so that any of them simply includes the corresponding

[PATCH] Improve timing of generation of generated test scripts.

2010-03-07 Thread Stefano Lattarini
@@ -1,3 +1,10 @@ +2010-03-07 Stefano Lattarini stefano.lattar...@gmail.com + + Improve timing of generation of generated test scripts. + * tests/Makefile.am (check_SCRIPTS): Add `$(parallel_tests)', so + that the generated `*-p.test' scripts are created before starting + to run the testsuite when `make

Re: [PATCH] Improve timing of generation of generated test scripts.

2010-03-08 Thread Stefano Lattarini
At Monday 08 March 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Sun, Mar 07, 2010 at 05:28:19PM CET: Anothor small cosmetic patch; it adds the list of generated tests ($(parallel_tests)) to the check_SCRIPTS variable, so that all

Re: [PATCH] Improve timing of generation of generated test scripts.

2010-03-13 Thread Stefano Lattarini
distdir run by 'make dist' provides such a convenience target. It does a little more, ... OK, I can live with this :-) Thanks for the tip, BTW. Regards, Stefano

Re: [PATCH 1/2] Avoid another use of `chmod -R'.

2010-03-30 Thread Stefano Lattarini
At Tuesday 30 March 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hi Stefano, thanks for the patch. * Stefano Lattarini wrote on Tue, Mar 30, 2010 at 05:52:21PM CEST: * Makefile.am (path-check): To be safe, do not use `chmod -R' on $(distdir) before removing it (as Solaris `chmod

[PATCH 0/3] Enable `errexit' a.k.a. `set -e' shell flag in all test scripts.

2010-03-31 Thread Stefano Lattarini
Hello automakers. I'll soon post a couple of patches enabling the `errexit' a.k.a. `set -e' shell flag unconditionally in all test scripts. This helps making the behaviour of different test scripts globally more consistent, and helps catching potential bugs that could lead to false negatives

Re: [PATCH 1/2] Avoid another use of `chmod -R'.

2010-03-31 Thread Stefano Lattarini
At Wednesday 31 March 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Stefano Lattarini wrote Ralf Wildenhues wrote: I'm not sure I understand. We are not putting any symlinks into $(distdir), why would this be needed? [CUT] to cater for the (admittedly very unlikely) case

[PATCH] Check that symlinks are resolved by `make dist'.

2010-04-01 Thread Stefano Lattarini
At Wednesday 31 March 2010, Stefano Lattarini stefano.lattar...@gmail.com wrote: [CUT] A testsuite addition that covers this would be welcome. Be sure to not fail if the system doesn't support symlinks (MinGW will emulate ln -s with cp -p). I'll write a couple of tests soonish, making

Re: [PATCH] Check that symlinks are resolved by `make dist'.

2010-04-04 Thread Stefano Lattarini
At Sunday 04 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Fri, Apr 02, 2010 at 12:29:49AM CEST: I'll write a couple of tests soonish, making them SKIP'd if `ln -s' fails, or if `test -h' fails when applied to the resulting

Re: [PATCH 0/3] Enable `errexit' a.k.a. `set -e' shell flag in all test scripts.

2010-04-04 Thread Stefano Lattarini
At Sunday 04 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Wed, Mar 31, 2010 at 01:24:05PM CEST: I'll soon post a couple of patches enabling the `errexit' a.k.a. `set -e' shell flag unconditionally in all test scripts. This helps

Re: [PATCH 0/3] Enable `errexit' a.k.a. `set -e' shell flag in all test scripts.

2010-04-07 Thread Stefano Lattarini
At Monday 05 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Sun, Apr 04, 2010 at 09:17:53PM CEST: At Sunday 04 April 2010, Ralf Wildenhues wrote: Another ChangeLog style remark: please don't list all files if you really adjust all files

Re: [PATCH 0/3] Enable `errexit' a.k.a. `set -e' shell flag in all test scripts.

2010-04-08 Thread Stefano Lattarini
At Sunday 04 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Wed, Mar 31, 2010 at 01:24:05PM CEST: I'll soon post a couple of patches enabling the `errexit' a.k.a. `set -e' shell flag unconditionally in all test scripts. This helps

Re: [PATCH 0/3] Enable `errexit' a.k.a. `set -e' shell flag in all test scripts.

2010-04-08 Thread Stefano Lattarini
: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 8 Apr 2010 10:54:16 +0200 Subject: [PATCH 1/2] Make test `aclocal3.test' stricter. * tests/aclocal3.test: Fail if $ACLOCAL succeds unexpectedly. Bumped copyright years. --- ChangeLog |6 ++ tests/aclocal3.test |4 ++-- 2

[PATCH] Avoid possible false negatives in cond46.test.

2010-04-08 Thread Stefano Lattarini
), and returns with a status of `0' otherwise (thus avoiding the possibility of false positives). From e7daa4e00f92b0a091710070832dd0e10a06e739 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 9 Apr 2010 01:27:23 +0200 Subject: [PATCH] Avoid possible false

[PATCH 2/2] Bugfix in confh5.test w.r.t. Solaris/Heirloom Sh.

2010-04-09 Thread Stefano Lattarini
* tests/confh5.test: In the generated Makefile.am: do not use `test ! -e FILE' to check for the non-existence of a file, since that is not supported by Solarish/Heirloom Sh. From c2711ecf6dd5c82f9d9819f5da8427caf8ad1d0e Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com

[PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives).

2010-04-09 Thread Stefano Lattarini
the `errexit' flag', such as nolink.test: grep '^meal.*:' Makefile.in | grep -v beef.meat Exit 1 and color.test: cat stdout | grep : pass | $FGREP $grn Exit 1 From 6c317d849d5fc580e6aa4919620fe2809fbb00f0 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 9 Apr

[PATCH 2/2] Some cleanup and cosmetic changes in confsub.test.

2010-04-09 Thread Stefano Lattarini
d08e93d8d03fcd21cd2e9c56ae6a84a4fd914c33 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 9 Apr 2010 18:43:22 +0200 Subject: [PATCH 2/2] Some cleanup and cosmetic changes in confsub.test. * tests/confsub.test: Prefer `echo' over `cat' to create one-line data files

Re: [PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives).

2010-04-09 Thread Stefano Lattarini
* tests/confsub.test: ... Also, bumped copyright years. Which I forgot to do. Sigh. An amended patch is attached. Sorry for the noise, Stefano From bd11ce65f4c8d0e4af29d6203f6e53c10cbf35f8 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Fri, 9 Apr 2010

Re: [PATCH 1/2] Use `set -e' in confsub.test (avoid false negatives).

2010-04-11 Thread Stefano Lattarini
At Sunday 11 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 07:25:31PM CEST: -$ACLOCAL || Exit 1 -$AUTOMAKE || Exit 1 +$ACLOCAL +$AUTOMAKE there is no need to actually remove these. Strictly speaking

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-11 Thread Stefano Lattarini
At Sunday 11 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 02:19:32AM CEST: Avoid possible false negatives in cond46.test. * tests/cond46.test: Enable shell `errexit' flag (and bumped copyright years). Due to this change

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-11 Thread Stefano Lattarini
At Sunday 11 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: How'd you suggest to shorten the log entry above, while keeping it meaningful? By cutting the part which I did not quote. :-) Oops, I missed that. Being verbose is fine for things that are unobvious, but you may

[PATCH] Fix typos in comments in test confh5.test

2010-04-11 Thread Stefano Lattarini
I've just found a couple of stupid typos in the last version of the patch. They are in a comment, so no big deal, but a fix is always welcome, right? Thanks, and sorry for the noise, Stefano From 8005809d6e64af309d2e4b5499ac93317f1f1d3b Mon Sep 17 00:00:00 2001 From: Stefano Lattarini

PATCH 1/2] Avoid possible false negatives in canon-name.test.

2010-04-11 Thread Stefano Lattarini
' otherwise (thus avoiding the possibility of false positives). From 31e6009bbe153c04f7d4fa6985364109db0dda05 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 8 Apr 2010 18:30:29 +0200 Subject: [PATCH 1/2] Avoid possible false negatives in canon-name.test

Re: [PATCH] Avoid possible false negatives in cond46.test.

2010-04-12 Thread Stefano Lattarini
At Monday 12 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: The analysis is required in any case. That doesn't mean it is necessary to mention it in the log message; because even if the analysis is hard work, in this case it is straight-forward. IOW, the size of the log

[PATCH] Refactor tests on Automake TESTS color output.

2010-04-14 Thread Stefano Lattarini
: Stefano Lattarini stefano.lattar...@gmail.com Date: Wed, 14 Apr 2010 13:52:51 +0200 Subject: [PATCH] Refactor tests on Automake TESTS color output. * tests/color.test: Tests using the expect program moved out to... * tests/color2.test: ... this new file. * tests/Makefile.am (TESTS): Extended

[PATCH] Fix typo in POD documentation of Automake::Channels.

2010-04-17 Thread Stefano Lattarini
A simple typofix in POD documentation. Regards, Stefano From e2bf5c7be520596a165935509c51b52f924faf85 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 17 Apr 2010 15:40:35 +0200 Subject: [PATCH] Fix typo in POD documentation of Automake::Channels. * lib

Re: [PATCH 1/2] Avoid possible false negatives in confh5.test.

2010-04-17 Thread Stefano Lattarini
At Friday 09 April 2010, Stefano Lattarini stefano.lattar...@gmail.com wrote: Avoid possible false negatives in confh5.test. * tests/confh5.test: Enable shell `errexit' flag, and bumped copyright years. Due to this change, any unexpected failure in calls to $ACLOCAL, $AUTOMAKE, $AUTOCONF

Re: [PATCH 2/2] Bugfix in confh5.test w.r.t. Solaris/Heirloom Sh.

2010-04-20 Thread Stefano Lattarini
At Tuesday 20 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Sat, Apr 17, 2010 at 03:56:05PM CEST: At Sunday 11 April 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 05:11:44PM CEST: * tests/confh5.test

Use `set -e' in confsub.test (avoid false negatives).

2010-04-20 Thread Stefano Lattarini
years. --- ChangeLog |7 +++ tests/confsub.test |8 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index a026c84..e9597c5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-04-20 Stefano Lattarini stefano.lattar

Re: Some warnings of type `unsupported' don't cause automake -Werror to fail

2010-04-20 Thread Stefano Lattarini
At Tuesday 20 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: I'm applying this fix. ... * tests/configure.test: New test. ... OK, I'm a dope... I found the bug while trying to write a test script for the copresence of configure.{in,ac}, but then I didn't include that

Re: pending patches (was: [PATCH 2/2] Bugfix in confh5.test w.r.t. Solaris/Heirloom Sh.)

2010-04-20 Thread Stefano Lattarini
At Tuesday 20 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hi Stefano, In fact, I'm assuming that you haven't answered the the recent still-pending patches' proposals basically for lack of time; Right. Those where I've merged your patches looked all fine to me. Sorry if

Re: Some warnings of type `unsupported' don't cause automake -Werror to fail

2010-04-20 Thread Stefano Lattarini
At Tuesday 20 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: AFAICS, your test doesn't ensure that without -Werror turned on, automake actually suceeds when both configure.ac and configure.in are present. *Blush*. You're right. Bad overlooking. OTOH, actually ensuring that

[PATCH] Make badopt.test stricter (by enabling `set -e').

2010-04-20 Thread Stefano Lattarini
avoiding the possibility of false negatives), and returns with a status of `0' otherwise (thus avoiding the possibility of false positives). From 64842626c8ac06e268bf4b9a644a021dee6461d8 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 8 Apr 2010 17:40:02 +0200

[PATCH 0/5] Modularize testing of automake silent-mode for languages != C

2010-04-22 Thread Stefano Lattarini
Hello automakers. Here I propose a series of patches to improve the granularity and modularity of the tests checking Automake's silent-mode with languages other than C. Currently, almost all these tests are crammed into the single test script `silent5.test'. This makes them more difficult to

[PATCH 1/5] New test silentlex.test (Automake/Lex silent-mode).

2010-04-22 Thread Stefano Lattarini
New test `silentlex.test': checks Automake silent-mode with Lex. * tests/silentlex.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From b66f995d3c861f66991abcd3a635e6bf506fa884 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 22 Apr 2010 21

[PATCH 2/5] New test silentyacc.test (Automake/Yacc silent-mode).

2010-04-22 Thread Stefano Lattarini
New test `silentyacc.test': checks Automake silent-mode with Yacc. * tests/silentyacc.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From 18460a891387aa84b7a92a9e5b8401da8202ae0a Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 22 Apr 2010

[PATCH 3/5] New test silentcxx.test (Automake/C++ silent-mode).

2010-04-22 Thread Stefano Lattarini
New test `silentcxx.test': checks Automake silent-mode with C++. * tests/silentcxx.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From f4354b30461779c150af5c281562e9e4ea414f64 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 22 Apr 2010 21

[PATCH 4/5] New tests for Automake silent-mode with Fortran.

2010-04-22 Thread Stefano Lattarini
New tests for Automake silent-mode with Fortran (77 and 90). * tests/silentf77.test: New test. * tests/silentf90.test: Likewise. * tests/Makefile.am (TESTS): Updated accordingly. From b13c7b13ef07fa92df96f643c3f0e463d32b6276 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar

[PATCH 5/5] Improved test silent5.test.

2010-04-22 Thread Stefano Lattarini
with other `silent*.test' tests. From 67d51f255ca50ffeff000308f33359d12568b675 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 22 Apr 2010 21:08:10 +0200 Subject: [PATCH 5/5] Improved test silent5.test. * tests/silent5.test: Removed by hand all generated C

[PATCH] Minor improvements in comments of silent3.test

2010-04-22 Thread Stefano Lattarini
, the comments in silent3.test tell to keep it in sync only with silent4.test, not mentioning silent9.test. The attached patch fixes this. Regards, Stefano From 3b34e3152a33e0fb128cd9843f7228915e251b72 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 22 Apr 2010

Re: [PATCH 5/5] Improved test silent5.test.

2010-04-25 Thread Stefano Lattarini
patch is attached). Thanks for working on this, Ralf Thanks to you for your quick review. Regards, Stefano From 571cfbdb78acb90644c445392d30aa58dca24146 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Thu, 22 Apr 2010 21:08:10 +0200 Subject: [PATCH 3/5] New

[PATCH] New tests: Heirlooom make and Lex/Yacc rules.

2010-04-25 Thread Stefano Lattarini
a couple of tests checking for the just described bug. Hopefully, a patch fixing this bug will follow soon. Regards, Stefano From 35ace11f38af8c02d542a1f2a444bf0bc6ada042 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sat, 24 Apr 2010 16:40:09 +0200 Subject

Re: [PATCH 5/5] Improved test silent5.test.

2010-04-25 Thread Stefano Lattarini
At Sunday 25 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: grep mv stdout Exit 1 On the contrary, this seems too much strict, since it would fail (with GNU make at least) if the automake source tree is placed in a directory whose name contains the `mv' substring.

Re: [PATCH 5/5] Improved test silent5.test.

2010-04-25 Thread Stefano Lattarini
At Sunday 25 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:13:11PM CEST: At Sunday 25 April 2010, Ralf Wildenhues wrote: Indeed. Grepping for '^mv ' and ' mv ' should work though. Or better again, we could strip off

[PATCH 0/9] Extend and improve tests on Automake's silent-mode

2010-04-25 Thread Stefano Lattarini
Hello automakers. Here I (re)propose a series of patches to improve and extend the tests on Automake's silent-mode. This series is an extension/improvement over my previous patch series [PATCH 0/5] Modularize testing of automake silent-mode for languages != C. For a reference see:

[PATCH 1/9] Relax silent-rules tests to cater for verbose makes.

2010-04-25 Thread Stefano Lattarini
copyright years. * tests/silent2.test: Likewise. * tests/silent3.test: Likewise. From 3d7b25b09b22324806a2ef805cf004cea3ba1b65 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 1/9] Relax silent-rules tests to cater

[PATCH 2/9] New test silentlex.test (Automake/Lex silent-mode).

2010-04-25 Thread Stefano Lattarini
* tests/silentlex.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From 1feeaf711427c19ec784fd4fbe5eab6442e55b9c Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 2/9] New test silentlex.test

[PATCH 4/9] New test silentcxx.test (Automake/C++ silent-mode).

2010-04-25 Thread Stefano Lattarini
* tests/silentcxx.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From 0d1ddd484c6b08e3136e7f60e6dc6acab5f5d9de Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 4/9] New test silentcxx.test

Subject: [PATCH 6/9] Improved test silent5.test.

2010-04-25 Thread Stefano Lattarini
grepping of make's output stricter. Improved/added some comments. From 7ae17054e4cb14af9481b1417b6190633013a817 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 6/9] Improved test silent5.test. * tests/silent5.test

[PATCH 7/9] Tests on silent-mode for C/Libtool made stricter.

2010-04-25 Thread Stefano Lattarini
/silent{4,9}.test. From 79fb4ca46afebe1554b1286ea6f5536c9edf3527 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 25 Apr 2010 22:52:30 +0200 Subject: [PATCH 7/9] Tests on silent-mode for C/Libtool made stricter. * tests/silent.test: Made stricter w.r.t

[PATCH 9/9] Tiny fix in silent8.test (display output of `make' command).

2010-04-25 Thread Stefano Lattarini
* tests/silent8.test: Make sure that the captured output of `make' command is always displayed. From f9d0ba1d8606dd147c9860fe305d0f0545f5292d Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Sun, 25 Apr 2010 23:05:18 +0200 Subject: [PATCH 9/9] Tiny fix in silent8

Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter.

2010-04-26 Thread Stefano Lattarini
At Monday 26 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Mon, Apr 26, 2010 at 12:15:33AM CEST: --- a/tests/silent6.test +++ b/tests/silent6.test @@ -99,5 +99,3 @@ $AUTOMAKE grep 'AM_V_GEN' Makefile.in $AUTOMAKE --force -Wno-all

[PATCH] Extend tests on `nostdinc' automake option.

2010-04-26 Thread Stefano Lattarini
/nostdinc2.test: New test. * tests/Makefile.am (TESTS): Extended accordingly. From c28ae289368b5cb8878a5618d5680f196ea48a55 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Mon, 26 Apr 2010 13:58:25 +0200 Subject: [PATCH] Extend tests on `nostdinc' automake option

Re: [PATCH] Extend tests on `nostdinc' automake option.

2010-04-26 Thread Stefano Lattarini
At Monday 26 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: Hello Stefano, * Stefano Lattarini wrote on Mon, Apr 26, 2010 at 02:05:19PM CEST: Extend tests on `nostdinc' automake option. * tests/nostdinc.test: Make the grepping of the generated Makefile.in slighty stricter

Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter.

2010-04-26 Thread Stefano Lattarini
At Monday 26 April 2010, Ralf Wildenhues ralf.wildenh...@gmx.de wrote: * Stefano Lattarini wrote on Mon, Apr 26, 2010 at 10:59:50AM CEST: By the way, I didn't understand if you're going to amend the patches yourself, or if I should do that instead... I can do that, but it's likely going

Re: [PATCH 2/9] New test silentlex.test (Automake/Lex silent-mode).

2010-04-26 Thread Stefano Lattarini
Patch updated (with the test slighty extended). From 307e75e5af537dd6e8fbeda4d000f3195d52469b Mon Sep 17 00:00:00 2001 From: Stefano Lattarini stefano.lattar...@gmail.com Date: Tue, 27 Apr 2010 02:01:30 +0200 Subject: [PATCH 2/9] New test silentlex.test (Automake/Lex silent-mode). * tests

  1   2   3   4   5   6   7   8   9   10   >