[avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-04 Thread Joerg Wunsch
Follow-up Comment #3, patch #8902 (project avr-libc): OK, I checked it (on something else), and think I understand it. Please go ahead, and commit it. Btw., this Web interface mangles patches. Better post them as attachments. ___ Reply

[avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-04 Thread Pitchumani
Update of patch #8902 (project avr-libc): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Follow-up Comment #4: Committed.

[avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-04 Thread Pitchumani
Follow-up Comment #1, patch #8902 (project avr-libc): Testcase: protected_write.c 1 #include 2 #include 3 4 void main () 5 { 6 _PROTECTED_WRITE(RTC_CTRL, RTC_PRESCALER_gm); 7 } Compiler output: $ avr-gcc -mmcu=atxmega128b1 -c protected_write.c In file included from

[avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-04 Thread Pitchumani
Follow-up Comment #2, patch #8902 (project avr-libc): This patch _PROTECTED_WRITE macro. Below is the disassembly (after applying the patch) for test in comment #1. : 0: cf 93 pushr28 2: df 93 pushr29 4: cd b7 in r28, 0x3d ;

[avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-03 Thread Pitchumani
URL: Summary: Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte Project: AVR C Runtime Library Submitted by: pitchumani Submitted on: Wed 03 Feb 2016

Re: [avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-03 Thread Joerg Wunsch
Hi Pitchumani, > Is this ok for trunk? If you are sure about it: yes. I tried to understand it, but without reviewing the respective datasheets and generated code, I could not decide whether it is correct or not. Ideally, this should be accompanied by a testcase in the testsuite, to

Re: [avr-libc-dev] [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers whose address is more than one byte

2016-02-03 Thread Sivanupandi, Pitchumani
> Subject: [patch #8902] Xmega's PROTECTED_WRITE is incorrect for IO registers > whose address is more than one byte > > URL: > > > Summary: Xmega's PROTECTED_WRITE is incorrect for IO > registers whose address is more than one byte