Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 11:56 PM, Maarten Maathuis <[EMAIL PROTECTED]> wrote: > On Thu, Nov 13, 2008 at 11:36 PM, Maarten Maathuis <[EMAIL PROTECTED]> wrote: >> On Thu, Nov 13, 2008 at 11:32 PM, Julien Danjou <[EMAIL PROTECTED]> wrote: >>> At 1226615131 time_t, Maarten Maathuis wrote: Last tim

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 11:36 PM, Maarten Maathuis <[EMAIL PROTECTED]> wrote: > On Thu, Nov 13, 2008 at 11:32 PM, Julien Danjou <[EMAIL PROTECTED]> wrote: >> At 1226615131 time_t, Maarten Maathuis wrote: >>> Last time i checked the data was malloc'ed, and the initial state >>> really needs to be fa

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 11:32 PM, Julien Danjou <[EMAIL PROTECTED]> wrote: > At 1226615131 time_t, Maarten Maathuis wrote: >> Last time i checked the data was malloc'ed, and the initial state >> really needs to be false. >> But i'll double check. > > No, it's p_new() which is calloc() so everything

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Julien Danjou
At 1226615131 time_t, Maarten Maathuis wrote: > Last time i checked the data was malloc'ed, and the initial state > really needs to be false. > But i'll double check. No, it's p_new() which is calloc() so everything is always clean. > It's either this or a force argument to wibox_moveresize(), ch

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 11:12 PM, Julien Danjou <[EMAIL PROTECTED]> wrote: > At 1226613172 time_t, Maarten Maathuis wrote: >> A much different patch. >> >> Setting XCB_WM_STATE_ICONIC on ban now, since that seems to be more >> appropriate (it seems the ICCCM definition of that was left >> intention

Re: [PATCH] revelation: Add arrow key behavior

2008-11-13 Thread Julien Danjou
At 1226602511 time_t, Espen Wiborg wrote: > As promised by the documentation comment for the keyboardhandler. Thanks, pushed. -- Julien Danjou // ᐰ <[EMAIL PROTECTED]> http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD signature.asc Description: Digital signature

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Julien Danjou
At 1226613172 time_t, Maarten Maathuis wrote: > A much different patch. > > Setting XCB_WM_STATE_ICONIC on ban now, since that seems to be more > appropriate (it seems the ICCCM definition of that was left > intentionally vague). Ok. > Note the wording "to indicate that a window would not be vis

[awesome bugs] #373 - X sometimes crashes when closing applications

2008-11-13 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#373 - X sometimes crashes when closing applications User who did this - Maarten Maathuis (madman2003) -- That sw is definately a bad pointer. My suspicion is that in wibox.c around line 174:

Re: [PATCH] better attempt at not unmapping windows upon hide

2008-11-13 Thread Maarten Maathuis
On Thu, Nov 13, 2008 at 7:25 AM, Maarten Maathuis <[EMAIL PROTECTED]> wrote: > On Wed, Nov 12, 2008 at 10:07 PM, Maarten Maathuis <[EMAIL PROTECTED]> wrote: >> On Wed, Nov 12, 2008 at 6:56 PM, Julien Danjou <[EMAIL PROTECTED]> wrote: >>> At 1226511972 time_t, Erik Garrison wrote: As discussed

[awesome bugs] #373 - X sometimes crashes when closing applications (Attachment added)

2008-11-13 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#373 - X sometimes crashes when closing applications User who did this - Espen Wiborg (espenhw) -- I just got awesome to crash by closing a Firefox window, and this time it dumped core. [EMAIL PR

[PATCH] revelation: Add arrow key behavior

2008-11-13 Thread Espen Wiborg
As promised by the documentation comment for the keyboardhandler. Signed-off-by: Espen Wiborg <[EMAIL PROTECTED]> --- lib/revelation.lua.in |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/revelation.lua.in b/lib/revelation.lua.in index 91ec984..d4ea09f 100644 --- a/

Re: awesome install_manifest

2008-11-13 Thread Alex Cornejo
Something I forgot to mention, after cloning the latest awesome head, I had to change the awesomeConfig.cmake to get it to compile, here is a patch to fix that (this however is unrelated to the bug discussed in this thread). Cheers, Alex On Thu, Nov 13, 2008 at 1:43 PM, Alex Cornejo <[EMAIL PR

Re: awesome install_manifest

2008-11-13 Thread Alex Cornejo
> Yes. This patch makes no sense to me since exluding .in files from > build_dir is useless: there should not be any .in file. > Can you clean everything using make distclean or git clean and doucle > check? I did something better than that: rm -fR awesome rm -fR /usr/share/awesome git clone git:

Re: Patch for equal distribution of slave clients over slave columns in tiling mode

2008-11-13 Thread Julien Danjou
At 1226545768 time_t, Norbert Zeh wrote: > as promised, I've made a patch to fix the unequal distribution of > windows over the slave columns in tiling mode. I don't seem to be able > to use git-send-email from my machine, as sendmail isn't configured. So > instead, I attach the file generated us

Re: [PATCH] awful.widget: Implement taglist.label.noempty in terms of label.all

2008-11-13 Thread Julien Danjou
At 1226567949 time_t, Espen Wiborg wrote: > This gives .noempty lovers a share in the taglist_squares goodness. Thanks Espen, pushed. Cheers, -- Julien Danjou // ᐰ <[EMAIL PROTECTED]> http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD signature.asc Description: D

Re: awesome install_manifest

2008-11-13 Thread Julien Danjou
At 1226525824 time_t, Alex Cornejo wrote: > PS: To Julien, I am still puzzled that this bug is not present in the > debian package? Is that debian package generated from the latest git > head? Yes. This patch makes no sense to me since exluding .in files from build_dir is useless: there should not

[awesome bugs] #373 - X sometimes crashes when closing applications

2008-11-13 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#373 - X sometimes crashes when closing applications User who did this - Konstantin Stepanov (kstep) -- The same is for me on FreeBSD 7. -- More information can be found at the following U

[awesome bugs] #372 - incorect available geometry in dual screen mode

2008-11-13 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#372 - incorect available geometry in dual screen mode User who did this - Julien Danjou (jd) -- This seems to be not a bug, in fact. Reading the source: 288 if ((d->screenCount == 1 || !isVi

[PATCH] awful.widget: Implement taglist.label.noempty in terms of label.all

2008-11-13 Thread Espen Wiborg
This gives .noempty lovers a share in the taglist_squares goodness. Signed-off-by: Espen Wiborg <[EMAIL PROTECTED]> --- lib/awful/widget.lua.in | 30 +- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/lib/awful/widget.lua.in b/lib/awful/widget.lua.in

[awesome bugs] #373 - X sometimes crashes when closing applications

2008-11-13 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#373 - X sometimes crashes when closing applications User who did this - Espen Wiborg (espenhw) -- This happens to me too. I've not been able to discern a pattern as to what applications trigger

[awesome bugs] #373 - X sometimes crashes when closing applications

2008-11-13 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#373 - X sometimes crashes when closing applications User who did this - Julien Danjou (jd) -- That depends on what you call crash. Does X crash or does awesome crashes? If it's awesome, please se