[Patch] titlebar: remove and readd on fullscreen change

2009-03-22 Thread Gregor Best
Hi people, the attached patches add calls to property hooks with before_ inserted before the property name and they change the behaviour of titlebars a bit, in that they are removed when a client is fullscreened and reattached if the client goes out of fullscreen mode. -- GCS/IT/M d- s+:- a---

Re: [Patch] titlebar: remove and readd on fullscreen change

2009-03-22 Thread Julien Danjou
At 1237733254 time_t, Gregor Best wrote: the attached patches add calls to property hooks with before_ inserted before the property name and they change the behaviour of titlebars a bit, in that they are removed when a client is fullscreened and reattached if the client goes out of

Re: [Patch] titlebar: remove and readd on fullscreen change

2009-03-22 Thread Gregor Best
At Sun, 22 Mar 2009 17:39:07 +0100 Julien Danjou wrote: At 1237733254 time_t, Gregor Best wrote: the attached patches add calls to property hooks with before_ inserted before the property name and they change the behaviour of titlebars a bit, in that they are removed when a client is

Re: [Patch] titlebar: remove and readd on fullscreen change

2009-03-22 Thread Gregor Best
At Sun, 22 Mar 2009 18:00:51 +0100 Julien Danjou wrote: At 1237740735 time_t, Gregor Best wrote: Yeah, sounds reasonable. To be honest, the .visible property didn't come to my mind, so I did all this ugly stuff :) Well, even without using .visible itself. :) We probably need to just not

[PATCH] titlebar: hide when the client is fullscreen

2009-03-22 Thread Maarten Maathuis
--- client.c |8 structs.h |4 titlebar.c | 18 -- 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/client.c b/client.c index da6262d..2d8a3a4 100644 --- a/client.c +++ b/client.c @@ -845,6 +845,11 @@ client_setfullscreen(client_t *c, bool

Re: [PATCH] titlebar: hide when the client is fullscreen

2009-03-22 Thread Julien Danjou
At 1237745920 time_t, Maarten Maathuis wrote: This seems a bit too much invasive. Isn't that possible to do what I suggested ? client_setfullscreen() trigers need_arrange, so you can update the banned status of the titlebar in it. I note that titlebars does not have banned status right now, maybe

Re: [PATCH] titlebar: hide when the client is fullscreen

2009-03-22 Thread Maarten Maathuis
What if a client is already unbanned, it will never hit the unban codepath. It just seemed unnatural to hack around it there. Completely separating client and titlebar banning might work. I don't have time right now to take a deeper look at that. Maarten. -- To unsubscribe, send mail to