Re: [PATCH] naughty margin

2009-04-04 Thread Julien Danjou
At 1238744120 time_t, Stefan Tibus wrote: Can someone review this patch? Thanks. -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // This is the end of my signature. signature.asc Description: Digital signature

[awesome bugs] #491 - Can't resume fullscreen freenx nxclient

2009-04-04 Thread awesome
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Micael Lee (mlee) Attached to Project - awesome Summary - Can't resume fullscreen freenx nxclient Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To

[PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Maarten Maathuis
- I don't see why we should guess about what we recieved and whatnot. --- client.c | 15 +-- client.h |1 + event.c | 24 3 files changed, 30 insertions(+), 10 deletions(-) diff --git a/client.c b/client.c index 3d9c8a7..771bd2c 100644 --- a/client.c

[PATCH 2/3] event: also filter leave notify events

2009-04-04 Thread Maarten Maathuis
--- event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/event.c b/event.c index ae90783..c89dbb6 100644 --- a/event.c +++ b/event.c @@ -456,6 +456,9 @@ event_handle_leavenotify(void *data __attribute__ ((unused)), wibox_t *wibox; client_t *c; +

[PATCH 3/3] wibox: kill misuse of phys_screen

2009-04-04 Thread Maarten Maathuis
- emwh and systray has some too, but the respective ewmh code is broken anyway and systrays are made on the first screen probably for a xinerama config --- wibox.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/wibox.c b/wibox.c index

Re: [PATCH 3/3] wibox: kill misuse of phys_screen

2009-04-04 Thread Julien Danjou
At 1238854563 time_t, Maarten Maathuis wrote: @@ -105,20 +105,20 @@ wibox_setposition(wibox_t *wibox, position_t p) * \param phys_screen Physical screen number. */ static void -wibox_systray_kickout(int phys_screen) +wibox_systray_kickout(int screen, int phys_screen) What the point of

Re: [PATCH 2/3] event: also filter leave notify events

2009-04-04 Thread Julien Danjou
At 1238854562 time_t, Maarten Maathuis wrote: 1 and 2 pushed. Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // Tomorrow I was nothing, yesterday I'll be. signature.asc Description: Digital signature

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Mariusz Ceier
This patch breaks Globally Active Input Model ... You can test it, using attached program. It creates 5 windows with 4 distinct input models ( there is twice No Input model used, in Satellite and No Input window ) When you move pointer over window with globally active input model, that window

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Julien Danjou
At 1238859251 time_t, Mariusz Ceier wrote: This patch breaks Globally Active Input Model ... You can test it, using attached program. It creates 5 windows with 4 distinct input models ( there is twice No Input model used, in Satellite and No Input window ) When you move pointer over window

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Mariusz Ceier
Julien Danjou pisze: At 1238859251 time_t, Mariusz Ceier wrote: This patch breaks Globally Active Input Model ... You can test it, using attached program. It creates 5 windows with 4 distinct input models ( there is twice No Input model used, in Satellite and No Input window ) When you move

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Maarten Maathuis
The satellite window is a noinput window, why would it ever get focus? Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Mariusz Ceier
Maarten Maathuis pisze: What about just allowing focus on noinput windows? Maarten. hmm, I don't have any argument against it :) If other clients can set focus on noinput window, why user couldn't ? ... I don't think that ICCCM does not permit this. Mariusz Ceier -- To unsubscribe, send

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Maarten Maathuis
I'm not quite sure why it broke (tried various extra changes), but i confirm that reverting the commit works. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH 1/3] event: add FocusOut handler

2009-04-04 Thread Julien Danjou
At 1238868303 time_t, Maarten Maathuis wrote: I'm not quite sure why it broke (tried various extra changes), but i confirm that reverting the commit works. Since we are not writing the first window manager :-) I'd suggest to test and copy behaviour from others. -- Julien Danjou // ᐰ