Both were expecting a client, but are actually passed a geometry.
Signed-off-by: Andreas Hübner an...@gmx.de
---
lib/awful/client.lua.in | 21 -
1 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/lib/awful/client.lua.in b/lib/awful/client.lua.in
index
From: Sébastien Gross seb•ɑƬ•chezwam•ɖɵʈ•org
Prevent from blinking the first screen in multiheads by using
the mouse-focused screen tag list for a new client instead of
screen 1.
Signed-off-by: Sébastien Gross seb•ɑƬ•chezwam•ɖɵʈ•org
---
lib/awful/tag.lua.in |2 +-
1 files changed, 1
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi,
this fixes some lua-triggerable crashes that happened because e.g. a client_t*
was interpreted as a wibox_t*. Commit messages explain more.
@jd:
No idea if
a) my fixes are correct (more testing needed, I only tested some stuff).
b) I covered
At 1252020371 time_t, Cedric GESTES wrote:
what do you think about that?
I think it's definitively the way to go.
--
Julien Danjou
// ᐰ jul...@danjou.info http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
// This is the end of my signature.
signature.asc
At 1251985082 time_t, Sébastien Gross wrote:
Both is_in_direction() and calculate_distance() expect clients
instead of geometries.
Thanks Seb, pushed. ;)
Cheers,
--
Julien Danjou
// ᐰ jul...@danjou.info http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
// There
At 1252007132 time_t, Cedric GESTES wrote:
dont set the geometry of a floating windows when the geometry is empty
What's the point of this patch? It should not change anything AFAICT.
--
Julien Danjou
// ᐰ jul...@danjou.info http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462
At 1252052734 time_t, Andreas Hübner wrote:
Both were expecting a client, but are actually passed a geometry.
While this patch is good, I've applied the one Sebastien Gross sent ealier,
which was simpler. :)
Anyway, thanks much for your contribution!
Cheers,
--
Julien Danjou
// ᐰ
it allow the following without failling:
-- force client on tag 5 to be floating and ontop
client.add_signal(new, function (c)
c:add_signal(tagged, function(c, t)
if t == tags[1][5] then
c.ontop = true
--yeah crappy but need to be set before floating
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Cedric GESTES wrote:
-c:geometry(property.get(c, floating_geometry))
+local geo = property.get(c, floating_geometry)
+if geo ~= nil then
+geo = c:geometry()
+end
Did you mean
yeah:
c:geometry(nil) :
W: awesome: luaA_dofunction:108: error while running function
stack traceback:
[C]: in function 'geometry'
[string c:geometry(42)]:1: in function 'f'
/usr/share/awesome/lib/awful/remote.lua:25: in function
/usr/share/awesome/lib/awful/remote.lua:21
At 1252064589 time_t, Cedric GESTES wrote:
A better solution is to check for nil in geometry?
Yes.
--
Julien Danjou
// ᐰ jul...@danjou.info http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
// Anna Molly! Anna Molly! Anna Molly!
signature.asc
Description:
At 1252061493 time_t, Uli Schlachter wrote:
No idea if
a) my fixes are correct (more testing needed, I only tested some stuff).
They seems to be.
b) I covered all the necessary places (I just grepped for luaA_object_ref).
That should do it.
Thanks for that. Pushed, of course.
Cheers,
--
sorry, fix a bug introduced with the customwidget.
From a7848134a7f5fe945796f35ec497aedfe9070a98 Mon Sep 17 00:00:00 2001
From: Cedric GESTES cta...@gmail.com
Date: Fri, 4 Sep 2009 14:39:53 +0200
Subject: [PATCH] titlebar: fix title and appicon position in the layout
Signed-off-by: Cedric GESTES
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi,
First patch fixes some valgrind invalid access errors and second one fixes a
valgrind leaked fd warning (libev leaked its epoll and signalfd file
descriptors).
Uli
- --
Do you know that books smell like nutmeg or some spice from a foreign
Hello,
I put this rule in my rc.lua :
{ rule = { class = MPlayer },
properties = { ontop = true, floating = true } },
As expected, my mplayer became on top and floating (but on the other
screen than the expected one). I can move it (and during the moving,
the window is resized o_O) and
At 1252072837 time_t, Uli Schlachter wrote:
Judging from my patch I think that atm there isn't anything which needs these
dangerous early signals. :/
And when we'll need them we will go back where we are now?
Running away is not a solution. So far, a part from the one bug you
found with
At 1252070161 time_t, Uli Schlachter wrote:
First patch fixes some valgrind invalid access errors and second one fixes a
valgrind leaked fd warning (libev leaked its epoll and signalfd file
descriptors).
Good catch, all in!
Cheers,
--
Julien Danjou
// ᐰ jul...@danjou.info
When compiling with -Wfloat-equal you will notice a few warnings about
unsafe comparison of floating points with == or != operators.
To get around this two functions a_compare_float a_compare_double
were created. They safely compare the two floating point numbers
within a given precision.
The first patch tells the doxygen preprocessor to parse D-Bus
functions, as well as enabling transparent background in the generated
dot images.
The second patch is a set of doxygen style comments for the D-Bus functions.
Thanks,
- Brian Gianforcaro
From 950f30540a874320bc39ed78a349a977cb00a73c
At 1252075326 time_t, Brian Gianforcaro wrote:
The first patch tells the doxygen preprocessor to parse D-Bus
functions, as well as enabling transparent background in the generated
dot images.
The second patch is a set of doxygen style comments for the D-Bus functions.
Both pushed, thanks.
On Fri, Sep 04, 2009 at 01:35:31PM +0200, Julien Danjou wrote:
While this patch is good, I've applied the one Sebastien Gross sent ealier,
which was simpler. :)
Wah, sorry - really should've checked the mailing list before sending
the patch. I was wondering where to send the patch, read PATCHES
Sorry for the personal response. The answer to is not set to awesome-devel…
do you tried the very last git version (after 1df4f1c6) ?
because there was a bug with some rules matching when they dont have too.
Hum… strange. I try to explain (I can do it in french if I’m not clear ;o))
I use
22 matches
Mail list logo