Re: [PATCH] unbash awesome-client

2009-06-12 Thread Paweł Zuzelski
On Fri, 12 Jun 2009, Paweł Zuzelski wrote:
 Attached patch checks if shell is bash. If no it disables use of
 non-standard read options.

 +READ_OPTIONS=-r
 (...)
 +while read ${USE_READLINE} -r ${READ_OPTIONS} line

One -r is enough. Sorry. I've attached a new version to this
e-maill.

-- 
Paweł Zuzelskixmpp/e-mail: z...@xatka.net
PLD Linux developer   http://pld-linux.org
diff --git a/utils/awesome-client b/utils/awesome-client
index a125869..e99faf3 100755
--- a/utils/awesome-client
+++ b/utils/awesome-client
@@ -1,7 +1,8 @@
 #!/bin/sh
 
 # rlwrap provides readline to stuff which doesn't know readline by itself
-RLWRAP=`which rlwrap 2/dev/null`
+RLWRAP=$(which rlwrap 2/dev/null)
+READ_OPTIONS=-r
 
 if [ $RLWRAP !=  ]
 then
@@ -10,7 +11,15 @@ then
 A_RERUN=no exec $RLWRAP $0
 fi
 else
-USE_READLINE=-e
+if [ $BASH ]
+then
+READ_PARAMETERS= -e
+fi
+fi
+
+if [ $BASH ]
+then
+READ_OPTIONS=$READ_OPTIONS -p awesome# 
 fi
 
 DBUS_SEND=dbus-send
@@ -32,7 +41,7 @@ a_dbus_send()
 $DBUS_METHOD string:$1 | tail -n +2
 }
 
-while read ${USE_READLINE} -r -p awesome#  line
+while read ${USE_READLINE} ${READ_OPTIONS} line
 do
 a_dbus_send $line
 done


Re: [PATCH] unbash awesome-client

2009-06-12 Thread Julien Danjou
At 1244790869 time_t, Paweł Zuzelski wrote:
 One -r is enough. Sorry. I've attached a new version to this
 e-maill.

Thanks, applied.

Cheers,
-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// My root password is


signature.asc
Description: Digital signature