Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244824357 time_t, Uli Schlachter wrote: Hm, awful you say? This is a little hidden tin here... Patch attached. I tested that gimp's toolboxes are still above and they (sadly?) are. Should they, is the question. According to git blame, this has been added by cf163797782038562fed70de52f65298ba87226c without any reason for EWMH compliance. I suggest to give a couple of test in other WM, and simply drop this code if we are conforming to everyone behaviour. I only have fluxbox installed (which doesn't do this) and #awesome seems a little unresponsive (I tested fluxbox, blackpenguin tested icewm, both dont do this), so let's read EWMH instead: Stacking order - -- To obtain good interoperability between different Desktop Environments, the following layered stacking order is recommended, from the bottom: * windows of type _NET_WM_TYPE_DESKTOP * windows having state _NET_WM_STATE_BELOW * windows not belonging in any other layer * windows of type _NET_WM_TYPE_DOCK (unless they have state _NET_WM_TYPE_BELOW) and windows having state _NET_WM_STATE_ABOVE *focused windows having state _NET_WM_STATE_FULLSCREEN Windows that are transient for another window should be kept above this window. The window manager may choose to put some windows in different stacking positions, for example to allow the user to bring currently a active window to the top and return it back when the window looses focus. Ok, so code in question sets the _NET_WM_STATE_ABOVE property (EWMH doesnt say anything about the WM setting this property) on windows which are neither normal nor desktop (which kind of fits EWMH) and which dont have a transient_for set (hm, dunno, I guess grouping windows and their transients is done elsewhere). So to me this looks like EWMH doesn't really require this. Now the question: Pushing the patch I already sent or, as jd suggests, just dropping the C code without adding the lua side of things? Cheers, Uli - -- Do you know that books smell like nutmeg or some spice from a foreign land? -- Faber in Fahrenheit 451 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iQEcBAEBCAAGBQJKNPQFAAoJECLkKOvLj8sG1aoH/3XCA6Gvx/lvQcugqafM1tAX vEcq6TyiJhN3BrrjWFEAz0R1FbWVHsvSkD/uMWCMqSiNyy7d1edV7Bs1+gpiInRM Xd6cOyXES0xcRQebOICDfA/etinqm9qHqDhTKnESkTmEYtEozjoRBUEn9MVjHzFw jt67mz5FJCRrcPlYsQ7NdtCDBJuUJ1Yktj7J6bctBXstNNXxErpj1i4WRqI/eV4+ 4i/Ojh9qcROZP1Ra/g8ywnIKTGDI7Z2tlcketyQkwjzZvq0g3QIiPFJaPnuD2ypZ P+JUvmx2dtFOQs+qZPy+ozVXIc3C9Ei08F3/dKhAXau+5SxRjsoiQclOJH9Gc2w= =T1rG -END PGP SIGNATURE- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
At 1244984327 time_t, Uli Schlachter wrote: So to me this looks like EWMH doesn't really require this. Now the question: Pushing the patch I already sent or, as jd suggests, just dropping the C code without adding the lua side of things? I just took the drop part of your patch. Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // Tomorrow I was nothing, yesterday I'll be. signature.asc Description: Digital signature
Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244824357 time_t, Uli Schlachter wrote: Hm, awful you say? This is a little hidden tin here... Patch attached. I tested that gimp's toolboxes are still above and they (sadly?) are. Should they, is the question. According to git blame, this has been added by cf163797782038562fed70de52f65298ba87226c without any reason for EWMH compliance. Hm, I think the client_setabove(c, false); which was added in there should be removed too, not? Oh and the commit message doesn't really git with the hunk which this thread is above. :/ I suggest to give a couple of test in other WM, and simply drop this code if we are conforming to everyone behaviour. I only have fluxbox on this box and (without any testing, just from memory) it doesn't do something like this. I never read the EWMH, so could you point to the paragraph which requires this behavior? Anyone knows some window manager where gimp's toolbox windows are above the real image window? Cheers, Uli - -- Do you know that books smell like nutmeg or some spice from a foreign land? -- Faber in Fahrenheit 451 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iQEcBAEBCAAGBQJKM1yoAAoJECLkKOvLj8sGXZ8IAKF9vhm4ssNTFCbcoATsn2J1 eLGGOKzmWf17L9p6Flm7gFW5i6bvAbmCHX8VA64hQdB5d8ISN0nnoOMcGasffIDn pLYBNJhpATfAWTkYF9fYVPPlw1+okAsthgF2zxWCqyg5YA3quvXI8f70LpTb8D3z JdxZ26n7Rs2SAep7eYAGKONQPs7W6d1eF+pjx4UBFaRY30gK1zorwKJdKwV6rzFB q6AVbf6lOehQ6HMbvRWE079nSRmKKmRD9n3748BuQowDjOQDNV9E/+/wI9+bXPmB pLWLV48fd8e6K3n/SpzSH3uwmqBLP3bUJADC3Wk8eY5LUZYIryw39ZzTVWmOV+8= =4Uu4 -END PGP SIGNATURE- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
Personally i like the ability of above and below, please don't remove it. Just make it optional if you feel strongly about it. Maarten. On Sat, Jun 13, 2009 at 10:00 AM, Uli Schlachterpsyc...@znc.in wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1244824357 time_t, Uli Schlachter wrote: Hm, awful you say? This is a little hidden tin here... Patch attached. I tested that gimp's toolboxes are still above and they (sadly?) are. Should they, is the question. According to git blame, this has been added by cf163797782038562fed70de52f65298ba87226c without any reason for EWMH compliance. Hm, I think the client_setabove(c, false); which was added in there should be removed too, not? Oh and the commit message doesn't really git with the hunk which this thread is above. :/ I suggest to give a couple of test in other WM, and simply drop this code if we are conforming to everyone behaviour. I only have fluxbox on this box and (without any testing, just from memory) it doesn't do something like this. I never read the EWMH, so could you point to the paragraph which requires this behavior? Anyone knows some window manager where gimp's toolbox windows are above the real image window? Cheers, Uli - -- Do you know that books smell like nutmeg or some spice from a foreign land? -- Faber in Fahrenheit 451 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iQEcBAEBCAAGBQJKM1yoAAoJECLkKOvLj8sGXZ8IAKF9vhm4ssNTFCbcoATsn2J1 eLGGOKzmWf17L9p6Flm7gFW5i6bvAbmCHX8VA64hQdB5d8ISN0nnoOMcGasffIDn pLYBNJhpATfAWTkYF9fYVPPlw1+okAsthgF2zxWCqyg5YA3quvXI8f70LpTb8D3z JdxZ26n7Rs2SAep7eYAGKONQPs7W6d1eF+pjx4UBFaRY30gK1zorwKJdKwV6rzFB q6AVbf6lOehQ6HMbvRWE079nSRmKKmRD9n3748BuQowDjOQDNV9E/+/wI9+bXPmB pLWLV48fd8e6K3n/SpzSH3uwmqBLP3bUJADC3Wk8eY5LUZYIryw39ZzTVWmOV+8= =4Uu4 -END PGP SIGNATURE- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Maarten Maathuis wrote: Personally i like the ability of above and below, please don't remove it. Just make it optional if you feel strongly about it. Heh, read the diff! ;) I'm not removing anything here, the current patch moves some behavior from the awesome C source (where it doesnt belong IMHO) into the awful lua code (where it does belong) which enables people to unregister the hook and thus disable this behavior. This patch doesn't remove any features or change the default behavior. Oh and this behavior: When I start gimp, all of its toolbox windows are c.above = true by default which means c:raise() on the image window doesn't have any effect at all. Cheers, Uli - -- Do you know that books smell like nutmeg or some spice from a foreign land? -- Faber in Fahrenheit 451 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iQEcBAEBCAAGBQJKM3KoAAoJECLkKOvLj8sGT08IAI05cGJplxVDcmmT6IETaxm7 CVRqO5Uj7BTLcJORSKRVl1HCcfyE8s6GsrsGPVgD767CYAkyjEVRlNIwGLSOyFZI l9WzWyTxEH92XbT9hJkHlVuX6b+1kclzIX+RlQ4XsO6v9edM7mS1uETCnwK1/LmZ HW7DW+vSoIJMPuzOLQ+dG7QomwkhCtY2qfg1/R3aTRPPx2TmQCTGlsDT+3PKrGFk yFWUAJV6TtLy8qfrs1yRo5C8m5W2n0YG7TYnXCEaPb6dfVuF9iR5C2ULG1JyiKfp zlLVHcQYHaB6M3JhZ2PObpfU423WWB1H3XfPK9Zn9ZnE14Az881x+yAh8z1IKMI= =tJs8 -END PGP SIGNATURE- -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
Oh btw, the reason they are above by default, is because dialogs are too. And these are longlasting dialogs. I don't think the ewmh does or should explicitly demand them to be above. The same goes for any dialog. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
Re: [Patch RFC] Move some code for setting certain clients above = true from C into lua
At 1244824357 time_t, Uli Schlachter wrote: Hm, awful you say? This is a little hidden tin here... Patch attached. I tested that gimp's toolboxes are still above and they (sadly?) are. Should they, is the question. According to git blame, this has been added by cf163797782038562fed70de52f65298ba87226c without any reason for EWMH compliance. I suggest to give a couple of test in other WM, and simply drop this code if we are conforming to everyone behaviour. Cheers, -- Julien Danjou // ᐰ jul...@danjou.info http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // There is nothing under this line. signature.asc Description: Digital signature
