Re: RFC/Testing: jd/padding branch

2009-05-10 Thread koniu
On Thu, May 7, 2009 at 19:23, Julien Danjou jul...@danjou.info wrote:
 At 1241720263 time_t, Andrei Thorp wrote:
 Alright, I'm out of bugs  thanks for patience. Good work.
 And thank you for taking time to test. :)

OK, so now its in next and I have no choice but to take that time and test :)

One thing I can say so far is that having get_workarea() in
awful.wibox is a bit counter-intuitive, it should go to awful.screen.
That would require adding a function to export the local 'wiboxes'
table in awful.wibox. Can provide patches if this sounds like a good
idea.

k

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.


Re: RFC/Testing: jd/padding branch

2009-05-10 Thread Julien Danjou
At 1241969514 time_t, koniu wrote:
 OK, so now its in next and I have no choice but to take that time and test :)
 
 One thing I can say so far is that having get_workarea() in
 awful.wibox is a bit counter-intuitive, it should go to awful.screen.
 That would require adding a function to export the local 'wiboxes'
 table in awful.wibox. Can provide patches if this sounds like a good
 idea.

Well, if that's possible, having a get_workarea in awful.screen handling
padding and wiboxes would be nice, sure.

I'll let the implementation detail up to you.

-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Trust no one.


signature.asc
Description: Digital signature


RFC/Testing: jd/padding branch

2009-05-07 Thread Julien Danjou
Hi,

These last days I've worked on moving the screen padding on Lua.
That's why the branch is named like that.

But well, I continued to dig and move some wibox code in Lua. The big
change is that all wiboxes are now floating. There's a set of useful
function in awful.wibox to move them, attach them etc, as before.

I did some tests, so far I did not spot anything very wrong, but since
this can be very… fragile, I'd prefer that people test it a bit before
merging into next.

Cheers,
-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// The more we fly, the more we climb, the more we know that heaven is a lie.


signature.asc
Description: Digital signature


Re: RFC/Testing: jd/padding branch

2009-05-07 Thread Andrei Thorp
I'll give a whirl.

-AT

On Thu, May 7, 2009 at 9:27 AM, Julien Danjou jul...@danjou.info wrote:
 Hi,

 These last days I've worked on moving the screen padding on Lua.
 That's why the branch is named like that.

 But well, I continued to dig and move some wibox code in Lua. The big
 change is that all wiboxes are now floating. There's a set of useful
 function in awful.wibox to move them, attach them etc, as before.

 I did some tests, so far I did not spot anything very wrong, but since
 this can be very… fragile, I'd prefer that people test it a bit before
 merging into next.

 Cheers,
 --
 Julien Danjou
 // ᐰ jul...@danjou.info   http://julien.danjou.info
 // 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
 // The more we fly, the more we climb, the more we know that heaven is a lie.

 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.4.9 (GNU/Linux)

 iEYEARECAAYFAkoC4ckACgkQpGK1HsL+5c0xcACgvQzyGUoFjHQj/Mou8nzgVzA0
 fn4AnR5KSBf+dRNBroGCjgtfN3iQZZXI
 =tgs/
 -END PGP SIGNATURE-



--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.


Re: RFC/Testing: jd/padding branch

2009-05-07 Thread Julien Danjou
At 1241711728 time_t, Andrei Thorp wrote:
 I'm trying to use the default config after a clean build/install of
 the latest. There seem to be three issues:
  - The wibox is only about an inch wide (doesn't stretch all the way along)

There's a call to stretch in the default config.
Check that you have this lines:

182 mywibox[s].screen = s 
183 -- Attach the wibox to top of the screen 
184 awful.wibox.attach(mywibox[s], top) 
185 -- Stretch the wibox so it takes the whole width 
186 awful.wibox.stretch(mywibox[1]) 

  - Windows overlap it
  - Doesn't respect the position argument (top regardless of whether I
 put left or not)

That's true, it's not used now.

 Other Info:
  - Dual monitor

Did not test dual monitor there might be bugs without the second bar. :)

  - Default config

I would bet no.

-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Trust no one.


signature.asc
Description: Digital signature


Re: RFC/Testing: jd/padding branch

2009-05-07 Thread Julien Danjou
At 1241711920 time_t, Julien Danjou wrote:
  Other Info:
   - Dual monitor
 
 Did not test dual monitor there might be bugs without the second bar. :)

Ok, I just did and it was broken. I fixed it and repushed my branch.

Cheers,
-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// In the Sixth Sense, Bruce Willis is dead.


signature.asc
Description: Digital signature


Re: RFC/Testing: jd/padding branch

2009-05-07 Thread Andrei Thorp
Right, sorry, I did screw up. DId it properly now with the default config.

  - Doesn't respect the position argument (top regardless of whether I
 put left or not)

 That's true, it's not used now.

I'd, for one, like this feature back eventually. It's nice to specify
the position rather than doing the attach step. Also note...
 - wibox.attach to the left works but it doesn't rotate the widgets
anymore. I have centered the label for the first tag, and the rest is
invisible. It's as if I would have a huge horizontal wibox, but I can
only see the leftmost 22 pixels of it (22 pixels is my wibox width,
and that seems to be working okay)


 Other Info:
  - Dual monitor

 Did not test dual monitor there might be bugs without the second bar. :)

Tried your latest change (mentioned in next e-mail) and have found
that a problem still exists. The first bar stretches, the second one
does not (still about an inch long). Still no errors in the log.

-AT

--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.


Re: RFC/Testing: jd/padding branch

2009-05-07 Thread Julien Danjou
At 1241716551 time_t, Andrei Thorp wrote:
 I'd, for one, like this feature back eventually. It's nice to specify
 the position rather than doing the attach step.

Well, that's not possible as a *feature*.

It'd be possible has a dirty hack for transition, eventually, yes.

Or we can add a constructor in awful.wibox to create wiboxes and attach
them automagically. But that'd be just sugar: you can blame me later for
that. :-)

 Also note...
  - wibox.attach to the left works but it doesn't rotate the widgets
 anymore. I have centered the label for the first tag, and the rest is
 invisible. It's as if I would have a huge horizontal wibox, but I can
 only see the leftmost 22 pixels of it (22 pixels is my wibox width,
 and that seems to be working okay)

Yes, you need to set the drawing orientation:
mywibox.orientation = south
or east (the default) or north. :)

  Other Info:
   - Dual monitor
 
  Did not test dual monitor there might be bugs without the second bar. :)
 
 Tried your latest change (mentioned in next e-mail) and have found
 that a problem still exists. The first bar stretches, the second one
 does not (still about an inch long). Still no errors in the log.

I fixed the configuration file as well; it had a stretch(mywibox[1])
instead of mywibox[s] :-)

Cheers,
-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Ferns will rule the world.


signature.asc
Description: Digital signature


Re: RFC/Testing: jd/padding branch

2009-05-07 Thread Julien Danjou
At 1241720263 time_t, Andrei Thorp wrote:
 Alright, I'm out of bugs  thanks for patience. Good work.

And thank you for taking time to test. :)

-- 
Julien Danjou
// ᐰ jul...@danjou.info   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
// Anna Molly! Anna Molly! Anna Molly!


signature.asc
Description: Digital signature