Re: [Patch] Drag'n'Dropping clients on tags

2008-12-15 Thread Julien Danjou
At 1229262041 time_t, Gregor Best wrote: > The attached patch splits awful.mouse.client.dragtotag into > awful.mouse.client.dragtotag.widget for the regular target selection by > dragging the client over a taglist and awful.mouse.client.dragtotag.border for > selecting the target tag by dragging th

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-14 Thread Gregor Best
The attached patch splits awful.mouse.client.dragtotag into awful.mouse.client.dragtotag.widget for the regular target selection by dragging the client over a taglist and awful.mouse.client.dragtotag.border for selecting the target tag by dragging the client over a screen border. -- Gregor Be

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-13 Thread Julien Danjou
At 1229112716 time_t, Gregor Best wrote: > As I read the BTS, i saw that Martin posted a comment some time ago in which > he > requested moving the client to the previous / next tag if it is moved to the > left / right side of the screen. The attached patch changes > awful.mouse.client.dragtotag()

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-12 Thread Gregor Best
As I read the BTS, i saw that Martin posted a comment some time ago in which he requested moving the client to the previous / next tag if it is moved to the left / right side of the screen. The attached patch changes awful.mouse.client.dragtotag() to take a further parameter, called "side", which i

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-09 Thread Julien Danjou
At 1228841120 time_t, Gregor Best wrote: > While fumbling around in awful.mouse, i noticed that my previous patch left > some useless variables and their assignments in > awful.mouse.client.dragtotag(). > Also i noticed that the function wouldn't work if the target tag's screen and > the client's

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-09 Thread Gregor Best
While fumbling around in awful.mouse, i noticed that my previous patch left some useless variables and their assignments in awful.mouse.client.dragtotag(). Also i noticed that the function wouldn't work if the target tag's screen and the client's screen were different. The attached patch fixes both

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-09 Thread Gregor Best
At Tue, 9 Dec 2008 11:00:54 +0100 Julien Danjou wrote: > > You are of course kidding me, aren't you? *g* > > I've cleaned it myself and merged it. > > Thanks anyway Gregor. :) > > Cheers, Lol, something went awfully wrong with that git format-patch :) Thanks for merging it anyway :D --

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-09 Thread Julien Danjou
At 1228762658 time_t, Gregor Best wrote: > > Please, be careful at this kind of detail, it's annoying. :) > > D'oh! I should've git diff'ed that, sorry :) > -local geom = c:fullgeometry() > +local geom = c:geometry() > @@ -91,7 +92,7 @@ function client.snap(c, snap, x, y) > > for

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-08 Thread Gregor Best
At Mon, 8 Dec 2008 10:00:49 +0100 Julien Danjou wrote: > Please, be careful at this kind of detail, it's annoying. :) > D'oh! I should've git diff'ed that, sorry :) > > +hooks.timer.register(0.001, ud) > > No, I won't accept that. I've no idea why you use this but if you > need, find anoth

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-08 Thread Julien Danjou
At 1228658700 time_t, Gregor Best wrote: > @@ -102,7 +103,7 @@ end > -- @param snap The pixel to snap clients. > function client.move(c, snap) > local c = c or capi.client.focus > - > + > if not c then return end > > if c.fullscreen Please, be careful at this kind of detail,

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-07 Thread Gregor Best
Resent to the list, I noticed my mistake today :P > At Thu, 4 Dec 2008 20:27:24 +0100 > Julien Danjou wrote: > > > I'd really like a version which *only* move to tag, to avoid switching > > client when moving the mouse. :) > > > Done, the new function is called awful.mouse.droptotag(c) > > > >

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-04 Thread Julien Danjou
At 1228408277 time_t, Gregor Best wrote: > Agreed, i added a new parameter to client.move, which, if set to true, will > enable drag and drop to move the client and I added a condition so that the > move only occurs if no mouse button had been pressed. I'd really like a version which *only* move t

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-04 Thread Gregor Best
At Thu, 4 Dec 2008 16:39:23 +0100 Julien Danjou <[EMAIL PROTECTED]> wrote: > I see several problems: > - you need to be very precise with your mouse. The actual move should be > done when you release the mouse button *over* a tag, not when the > mouse is over it. > - having this in the same fu

Re: [Patch] Drag'n'Dropping clients on tags

2008-12-04 Thread Julien Danjou
At 1228404579 time_t, Gregor Best wrote: > diff --git a/lib/awful/mouse.lua.in b/lib/awful/mouse.lua.in > index a9443f2..c9da833 100644 > --- a/lib/awful/mouse.lua.in > +++ b/lib/awful/mouse.lua.in > @@ -9,6 +9,7 @@ local layout = require("awful.layout") > local tag = require("awful.tag") > local

[Patch] Drag'n'Dropping clients on tags

2008-12-04 Thread Gregor Best
Hi people, the attached patch allows dragging clients over a tag to move them to that specific tag. It is a response to FlySpray feature request #157. Gregor Best From 32d12f1044a7c1c1a83f85bbf5be264ab43ce3be Mon Sep 17 00:00:00 2001 From: Gregor Best <[EMAIL PROTECTED]> Date: Thu, 4 Dec