Re: [Patch] Make window_hasproto non-blocking (was: [awesome bugs] #543 - Split window_hasproto)

2009-06-25 Thread Julien Danjou
At 1245869654 time_t, Uli Schlachter wrote: +void +property_update_wm_protocols(client_t *c) +{ +xcb_get_wm_protocols_reply_t protocols; + +if(xcb_get_wm_protocols_reply(globalconf.connection, + xcb_get_wm_protocols_unchecked(globalconf.connection,

Re: [Patch] Make window_hasproto non-blocking

2009-06-25 Thread Julien Danjou
At 1245918857 time_t, Uli Schlachter wrote: BTW in my testing only my test app ever triggered this code and I don't really see any reason why someone would change their WM_PROTOCOLS, so I think this is less bad than it looks (Plus some other function in there already does the same *duck*).

Re: [Patch] Make window_hasproto non-blocking

2009-06-25 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Uli Schlachter wrote: Julien Danjou wrote: At 1245919316 time_t, Uli Schlachter wrote: So it doesn't really forbid it. ;) Should I use 'protocols-_reply != NULL' as a check when to xcb_get_wm_protocols_reply_wipe()? Yes. Attached are the

Re: [Patch] Make window_hasproto non-blocking

2009-06-25 Thread Julien Danjou
At 1245920036 time_t, Uli Schlachter wrote: Attached are the new patches and a diff between the first version and this one. (Ignore the lib/awful/widget/progressbar.lua.in hunk, the new version was rebased on master while the old one wasnt) Pushed. Thanks so much. Cheers, -- Julien Danjou

[Patch] Make window_hasproto non-blocking (was: [awesome bugs] #543 - Split window_hasproto)

2009-06-24 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 awesome wrote: THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Julien Danjou (jd) Attached to Project - awesome Summary - Split window_hasproto Task Type -