On Sun, May 6, 2012 at 2:00 PM, Uli Schlachter <psyc...@znc.in> wrote: > On 06.05.2012 04:20, Anurag Priyam wrote: >> Uli, what's with the `colstr` variable? It doesn't seem to be used >> anywhere. Same for the `if c:get_type()` block. Doesn't look like >> anything is being done with the rgba values that it computes. I >> wonder if this (attached patch) is the right approach: > > This was added in commit 07bbe14d02. The problem was that whenever the wibox > needed to be drawn, the X server first filled that area with black and only [...]
Makes sense.
>> function set_bg(wibox, c)
[...]
>> + c = string_format("#%02x%02x%02x", r, g, b)
>> end
>> wibox.background_color = c
>> wibox.draw()
>
> This patch is wrong. wibox.background_color must always be a cairo pattern
> object and not a string. If it really gets set to "#000000", everytime a wibox
> gets redrawn, oocairo will throw a lua error about "cr:set_source() needs a
> Cairo pattern or surface object as argument 2".
Ok. I thought the computed rgb values had to be used.
> Could you send (to awesome-devel) two new patches? First one will be
[...]
Attached.
--
Anurag Priyam
0001-wibox-assume-a-default-background-and-foreground-col.patch
Description: Binary data
0002-wibox.set_bg-remove-historical-cruft.patch
Description: Binary data
