Hello, Kumar.
Thank you for the review.
> Is there a regression test for this somewhere ?
It's quite hard to create a regression test for this issue, as we would need
SWT for such test and we do not have any tests which use SWT currently.
I have tried to make a test without SWT using some appl
Changeset: 70ac1bf74865
Author:serb
Date: 2013-05-27 22:31 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/70ac1bf74865
8014726: TEST_BUG:
java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java should be
modified
Reviewed-by: serb, anthony
Contributed-by: alexander
This looks reasonable to me. Did you test the fix using the "leaks" to
determine that the descriptors or the block itself were not over-retained?
Regards,
Mike Swingler
Apple Inc.
On May 27, 2013, at 6:53 AM, Anthony Petrov wrote:
> Thanks for testing, James. I'm fine with the fix then.
>
> N
Hello,
Please review a fix for the issue:
8012569 TEST_BUG: java/awt/GraphicsDevice/CheckDisplayModes.java fails
Test bug fix. Move from closed to openjdk repo.
http://bugs.sun.com/view_bug.do?bug_id=8012569
The webrev is: http://cr.openjdk.java.net/~kshefov/8012569/webrev.00
Thanks,
Konstan
Looks fine.
--
best regards,
Anthony
On 05/27/13 13:48, Alexander Zvegintsev wrote:
Hi all,
Please review fix for http://bugs.sun.com/view_bug.do?bug_id=8014726 :
http://cr.openjdk.java.net/~art/alexz/8014726/webrev.00/
Adding missing JTREG tags solves this issue.
Hello,
Please review a fix for the issue:
8013027 TEST_BUG: There are no java-cup icons inside the frame for
TestUnixDefaultIcon.java.
Test bug fix. Move from closed to openjdk repo.
http://bugs.sun.com/view_bug.do?bug_id=8013027
The webrev is: http://cr.openjdk.java.net/~kshefov/8013027/we
Thanks for testing, James. I'm fine with the fix then.
Note that we need at least one more review from a reviewer on this
mailing list before we can push your fix to the repository.
Anyone?
--
best regards,
Anthony
On 05/24/13 22:39, James Tomson wrote:
Hi Anthony,
Thanks for taking a look
Looks fine. I would just use System.out instead of System.err to report
that no capable GraphicsConfiguration is found.
Thanks,
Artem
On 5/21/2013 7:12 PM, Anthony Petrov wrote:
Hello,
Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7039616 at:
http://cr.openjdk.java.net/~a
Hello,
Could you review the fix, please?
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015375
webrev: http://cr.openjdk.java.net/~vkarnauk/8015375/webrev.00/
The function XNextSecondaryLoopEvent() should use a progressive time out
value instead of hardcoded 250 msces during s
Hi, Alexander.
Fix looks good.
On 27.05.2013 13:48, Alexander Zvegintsev wrote:
Hi all,
Please review fix for http://bugs.sun.com/view_bug.do?bug_id=8014726 :
http://cr.openjdk.java.net/~art/alexz/8014726/webrev.00/
Adding missing JTREG tags solves this issue.
--
Best regards, Sergey.
Hi all,
Please review fix for http://bugs.sun.com/view_bug.do?bug_id=8014726 :
http://cr.openjdk.java.net/~art/alexz/8014726/webrev.00/
Adding missing JTREG tags solves this issue.
--
Thanks,
Alexander.
Changeset: c36626831f07
Author:vkarnauk
Date: 2013-05-27 12:47 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c36626831f07
8010721: [macosx] In JDK7 the menu bar disappears when a Dialog is shown
Reviewed-by: anthony, serb
! src/macosx/classes/sun/lwawt/macosx/CPlatformWind
12 matches
Mail list logo