Re: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix

Antony, Thanks for the review. Here's the renewed link covering the gaps. -- Thanks kalyan On 8/23/13 3:44 AM, Anthony Petrov wrote: Hi Srikalyan, Thanks for fixing the warnings. A couple of comments: src

hg: jdk8/awt/jdk: 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE

Changeset: f983fd18dd81 Author:malenkov Date: 2013-08-23 19:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f983fd18dd81 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistence

Re: [8] Review request for 8023474: First mousepress doesn't start editing in JTree

Hi Dmitry, The fix looks good to me. As to the test, you should dispose() the frame before the if (!result){} statement, so that the test could exit when it passes. -- best regards, Anthony On 08/23/2013 04:18 PM, dmitry markov wrote: Hi Anthony, Thank you for your comments. I changed the

Re: [8] Review request for 8023474: First mousepress doesn't start editing in JTree

Hi Anthony, Thank you for your comments. I changed the fix based on your suggestions. Please find new webrev at http://cr.openjdk.java.net/~dmarkov/8023474/webrev.01/. Could you review it, please? Thanks, Dmitry On 22/08/2013 17:28, Anthony Petrov wrote: Hi Dmitry, A few comments: 1. The

Re: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix

Hi Srikalyan, Thanks for fixing the warnings. A couple of comments: src/share/classes/java/awt/KeyboardFocusManager.java 3065 proxyActive = (Field) AccessController.doPrivileged(new PrivilegedAction() { I suppose an explicit type-cast may now be removed from here. src/share/cla

Re: [8] Review request for 8022401 [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails

Hi Alexander, The fix looks fine to me. However, please correct the year in the copyright notice in the test before pushing your fix, since currently it lists 2011 instead of 2013. -- best regards, Anthony On 08/22/2013 06:28 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix