AWT Dev [8] Review Request: JDK-7124363 [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer

2013-09-30 Thread Petr Pchelko
Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-7124363 The fix is available at: http://cr.openjdk.java.net/~pchelko/7124363/webrev.00/ This is a direct forward port form JDK-7. We do not need to set a fileDialog as a blocker, because it's natively

Re: AWT Dev [8] Review Request: JDK-7124363 [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer

2013-09-30 Thread Sergey Bylokhov
Hi. Petr. The fix looks good. On 30.09.2013 13:25, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-7124363 The fix is available at: http://cr.openjdk.java.net/~pchelko/7124363/webrev.00/ This is a direct forward port form

Re: AWT Dev [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

2013-09-30 Thread mikhail cherkasov
Hi All, Just a friendly reminder, I'm still waiting for review. Thanks, Mikhail. On 27.09.2013 19:32, mikhail cherkasov wrote: Anthony thank you for this link, it's good replacement for removed link. Also I didn't find replacement for : - * Also see the article a

Re: AWT Dev [8] Request for review: 7150100 [macosx] 0123456789 is selected in the TextField.

2013-09-30 Thread Artem Ananiev
The new version of the fix still looks fine. Thanks, Artem On 9/27/2013 2:13 PM, Sergey Bylokhov wrote: Hello. Please review the updated version of the fix for jdk 8. The same problem was found and fixed in xawt as well. http://cr.openjdk.java.net/~serb/7150100/webrev.01 On 09.04.2012

AWT Dev [8] Review request for 8025652: [macos] build failed

2013-09-30 Thread sergey malenkov
Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/8025652.8.0/ http://cr.openjdk.java.net/%7Emalenkov/8025652.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8025652 This is a regression after the 7117595 fix. Thanks, SAM

AWT Dev hg: jdk8/awt/jdk: 7150100: [macosx] 0123456789 is selected in the TextField

2013-09-30 Thread sergey . bylokhov
Changeset: cdfa2301a291 Author:serb Date: 2013-10-01 04:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cdfa2301a291 7150100: [macosx] 0123456789 is selected in the TextField Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java !

AWT Dev [7u] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-30 Thread dmitry markov
Hello, Could you review a back-port of 7129133 to JDK 7u, please? The back-port and the main fix integrated into jdk8 are slightly different. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev for jdk7u: http://cr.openjdk.java.net/~dmarkov/7129133/webrev.00/ jdk8 changeset: