Hi All
Please review the fix at
http://cr.openjdk.java.net/~weijun/7025699/webrev.00/
The fix includes porting PolicyTool from AWT to Swing, defining
mnemonics for menu items and buttons, and adding keyboard shortcuts for
the File - New/Open/Save items. Several tests are updated also.
Changeset: d874963706dc
Author:yan
Date: 2013-10-14 11:47 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d874963706dc
8025824: [cleanup] Fix tidy errors and warnings in preformatted HTML files
related to 2d/awt/swing
Reviewed-by: anthony, alexsch
!
Changeset: 69a17384fe22
Author:malenkov
Date: 2013-10-14 13:22 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/69a17384fe22
7165112: Incomprehensible garbage in doc for RootPaneContainer
Reviewed-by: alexsch
! src/share/classes/javax/swing/JApplet.java
!
Changeset: 9f49b055e983
Author:malenkov
Date: 2013-10-14 13:59 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9f49b055e983
7016396: (spec) JCK test mentioned in 6735293 is still failing
Reviewed-by: alexsch
! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java
!
Changeset: 54a6e22b749c
Author:malenkov
Date: 2013-10-14 14:13 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/54a6e22b749c
7035495: javax.swing.ImageIcon spec should be clarified
Reviewed-by: alexsch
! src/share/classes/javax/swing/ImageIcon.java
Hi, Anton,
thanks for details description of the bug and suggested fix. It helped a
lot.
My understanding is that the problem is not with step 2, but step 3.
Generating drag entered events on mouse press looks incompatible, I
can't predict side effects of such a change. Fixing step 3, so we
Hi Sergey,
The fix looks good to me.
--
best regards,
Anthony
On 10/11/2013 02:10 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 8. The problem is in inconsistent state of
the GraphicsDevice, Window and Peer.
We update GraphicsDevice synchronously in setFullScreenWindow(),
Hi, Sergey,
the fix looks acceptable (I can't say fine, because I can't predict
side effects). That's why could you also add the following information
to bug comments:
1. Current fix
2. Alternative fix, when we asynchronously update GD's full screen window
Thanks,
Artem
On 10/11/2013 6:10
Changeset: 5e0ed469c36a
Author:alexsch
Date: 2013-10-14 18:19 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5e0ed469c36a
8005391: Floating behavior of HTMLEditorKit parser
Reviewed-by: malenkov, leonidr
Contributed-by: Alexander Shusherov alexander.shushe...@oracle.com
!
Hi Artem,
with the fix the 'drag entered' event is actually generated on the
mouse move event (step 2). Currently this first move event is 'consumed'
by the MouseGestureRecognizer and is not treated as the part of a drag
operation, while this move could be important (as in our case).
Changeset: 24fd0716d8d6
Author:alexsch
Date: 2013-10-14 18:52 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/24fd0716d8d6
8020708: NLS mnemonics missing in SwingSet2/JInternalFrame demo
Reviewed-by: malenkov, leonidr
!
Changeset: 9546631f14ca
Author:serb
Date: 2013-10-14 20:11 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9546631f14ca
8019591: JCK: testICSEthrowing_fullScreen fails: no ICSE thrown
Reviewed-by: art, anthony
! src/share/classes/java/awt/GraphicsDevice.java
+
Hi Jim, Thanks for reviewing and apologies for the delayed response, I
have made sure to set the properties type as String - Object but mostly
the public constructor(OR) setter method enforces ?, ? where Object,
Object being too loose is guaranteed to not break at runtime but
String, Object is
Thanks Kalyan,
I'll leave the review and approval to someone else because, as I said, I
was asking an idle question from a limited understanding of the
compatibility issues of generifying code, and a bit of historical
perspective from the origin of the APIs...
...jim
14 matches
Mail list logo
