Hello, AWT Team.
Sorry for this mess with reviews, could you please review yet another version
of this fix:
The bug: http://bugs.openjdk.java.net/browse/JDK-8027152
Th fix: http://cr.openjdk.java.net/~pchelko/8027152/webrev.02/
The alwaysOnTop property would be applied to the owned windows when
Hi, Petr.
As far I understand we never check the ownedWindowList to null, since we
initialize it even before the constructor call. The problem exists only
in deserialisation code before we init this field. So from my point of
view the first version of the fix was better.
On 28.10.2013 12:26,
Hi, Alexander,
a few comments:
1. SunGraphics2D.java:3076 - should isHiDPIImage() be used here?
2. I'm not sure that the proposed getScaledImageName() implementation in
ScalableToolkitImage works perfectly for URLs like this:
http://www.exampmle.com/dir/image
In this case it will try to
Hi, Petr.
The fix looks good.
On 28.10.2013 14:42, Petr Pchelko wrote:
Hello, Sergey.
Thank you for the review, here's the updated version:
http://cr.openjdk.java.net/~pchelko/8027152/webrev.03/
With best regards. Petr.
On 28.10.2013, at 14:19, Sergey Bylokhov sergey.bylok...@oracle.com
Hi Leonid,
The fix looks somewhat risky so late in the release. But I talked with
Sergey and I see that it resolves a lot of real problems. So I'm sort of
OK with it. A few comments:
src/macosx/native/sun/awt/AWTWindow.m
255 self.preFullScreenLevel = [self.nsWindow level];
The
Thanks.
Artem
On 10/25/2013 5:45 PM, Anton V. Tarasov wrote:
Hi Artem,
On 10/24/13 6:59 PM, Artem Ananiev wrote:
Hi, Anton,
it looks much better now. Is it possible to create a regression test
for this change?
Ok, I did that. Here's the test:
