Hello AWT dev,
I have a pet issue that prevents me from using NetBeans 7.4+ on Mac OS X
because I use the DVORAK keyboard layout [1]. Basically, when I press
Ctrl-e to go to the end of the line, the system things I'm pressing
Ctrl-d, and deletes a character. According to this research from Svata
Hi Yuri,
I updated the webrev to remove conflicts with the changeset in the 2D
repository.
I will push on Tuesday based on your OK comment unless I hear otherwise.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-lint-awt-8028019/
Thanks, Roger
On 11/28/2013 3:32 AM, Yuri Nesterenko wrot
Hi Alexander,
There must have been a miscommunication. While I think the cache has
some issues that worry me, it is absolutely needed if you are going to
wrap the observer. You can't just delete it and re-wrap the observer on
every call because that will create a number of problems. If you
Hi Sergey,
The fix looks fine to me.
--
best regards,
Anthony
On 12/02/2013 08:37 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 8.
The new test is for "apple.awt.fileDialogForDirectories" property, which
was added in the JDK-7161437
Bug: https://bugs.openjdk.java.net/browse/
Hello.
Please review the fix for jdk 8.
The new test is for "apple.awt.fileDialogForDirectories" property, which
was added in the JDK-7161437
Bug: https://bugs.openjdk.java.net/browse/JDK-8029382
Webrev can be found at: http://cr.openjdk.java.net/~serb/8029382/webrev.00
--
Best regards, Sergey
+1
--
best regards,
Anthony
On 12/02/2013 06:54 PM, Artem Ananiev wrote:
Hi, Anton,
the new version is fine. Thanks for addressing my comments,
Artem
On 12/2/2013 6:52 PM, Anton Litvinov wrote:
Hello Artem,
Thank you for review of this fix. Could you please review the second
version of the
Hello Artem,
Thank you for review of this fix. Could you please review the second
version of the fix, which should follow your remarks.
Webrev: http://cr.openjdk.java.net/~alitvinov/8025775/jdk8/webrev.01
Differences between this version of the fix and the previous version are
following:
1
Hi, Anton,
the new version is fine. Thanks for addressing my comments,
Artem
On 12/2/2013 6:52 PM, Anton Litvinov wrote:
Hello Artem,
Thank you for review of this fix. Could you please review the second
version of the fix, which should follow your remarks.
Webrev: http://cr.openjdk.java.net/
Hi, Andrei.
The fix looks good.
On 12/2/13 4:12 PM, andrei.eremeev wrote:
Sorry.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8023576
Fix:
http://cr.openjdk.java.net/~yan/8023576/webrev.00/
Andrei
On 12/02/2013 03:37 PM, Sergey Bylokhov wrote:
On 12/2/13 1:45 PM, andrei.eremeev wrote:
Hi,
Hi Anton,
The fix looks good to me.
--
best regards,
Anthony
On 11/30/2013 02:13 AM, Anton Litvinov wrote:
Hello,
Could you please review the following fix for the bug, which consists in
invocation of Java methods from native code via JNI ("TryXShmAttach"
function in "awt_GraphicsEnv.c" file)
Hi Andrei,
The fix looks fine to me.
--
best regards,
Anthony
On 12/02/2013 04:12 PM, andrei.eremeev wrote:
Sorry.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8023576
Fix:
http://cr.openjdk.java.net/~yan/8023576/webrev.00/
Andrei
On 12/02/2013 03:37 PM, Sergey Bylokhov wrote:
On 12/2/13
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8011059/webrev.12/
- Image observers are not cached now for the resolution variants
- base image width and height are checked in the wrapped image observer
On 11/30/2013 3:27 AM, Jim Graham wrote:
Hi Alexander,
Sorry.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8023576
Fix:
http://cr.openjdk.java.net/~yan/8023576/webrev.00/
Andrei
On 12/02/2013 03:37 PM, Sergey Bylokhov wrote:
On 12/2/13 1:45 PM, andrei.eremeev wrote:
Hi, AWT team.
Please review the fix for the issue:
https://bugs.openjdk.java.ne
On 12/2/13 1:45 PM, andrei.eremeev wrote:
Hi, AWT team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8023576
The fix is available at:
http://cr.openjdk.java.net/~yan/8023576/webrev.00/
Looks like the link is incorrect? There is nothing about a test.
The proble
Hi, AWT team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8023576
The fix is available at:
http://cr.openjdk.java.net/~yan/8023576/webrev.00/
The problem:
1. test can not find Util.java during compilation.
2. jtreg thinks that test failed if System.exit was cal
Hi, Anton,
the fix looks fine in general. A few minor comments:
1. xerror_code is not used now and can be removed. XERROR_SAVE seems to
be unused as well.
2. current_native_xerror_handler can be declared as "extern" in
awt_util.h, so you don't need to declare it in every file where it's
use
16 matches
Mail list logo
