Hello, Anthony.
Thank you for the review.
Actually we have quite a lot of binary images in tests, but in this particular
case the image could be generated on the fly.
Please review the updated version of the fix:
http://cr.openjdk.java.net/~pchelko/9/8024185/webrev.01/
Only test test is
Looks great. Thank you!
I suppose we might even want to put the GenerateTestImage.java file to
the test/java/awt/SplashScreen/ directory so that we could use it for
other splash screen tests in the future.
--
best regards,
Anthony
On 12/19/2013 12:06 PM, Petr Pchelko wrote:
Hello, Anthony.
Hello, Anthony.
I suppose we might even want to put the GenerateTestImage.java file to the
test/java/awt/SplashScreen/ directory so that we could use it for other
splash screen tests in the future.
Sure. I'll do that prior to the push.
With best regards. Petr.
On 19.12.2013, at 13:53,
Hello AWT team,
I am currently looking at JDK-6464548 issue[1], and as you can see in
javadoc[2]
we have only setMinimumSize() implemented in java.awt.Window and
setMaximumSize() is not implemented.
So my question is about how setMaximumSize() (and setMinimumSize())
should interfere with
On 12/19/2013 2:46 PM, Alexander Zvegintsev wrote:
Hello AWT team,
I am currently looking at JDK-6464548 issue[1], and as you can see in
javadoc[2]
we have only setMinimumSize() implemented in java.awt.Window and
setMaximumSize() is not implemented.
So my question is about how
Hi , Petr.
The fix looks fine.
ps:
174 if (popupMenu != null popupMenu.getInvoker()
!=*LWChoicePeer.this.getTarget()*) {
180 popupMenu.show(*getTarget()*, loc.x, loc.y);
On 19.12.2013 11:49, Petr Pchelko wrote:
Hello, Anthony, Sergey.
Thank you for the review.
The new version could
Hello, Sergey.
174 if (popupMenu != null popupMenu.getInvoker() !=
LWChoicePeer.this.getTarget()) {
180 popupMenu.show(getTarget(), loc.x, loc.y);
Oh, just forgot to update it. Thank you.
With best regards. Petr.
On 19.12.2013, at 16:11, Sergey Bylokhov sergey.bylok...@oracle.com
Hi Jim and all,
Thinking of getting rid of the need to use BuffedImage at all for JLF, I'm facing the following
obstacles:
1. We have to forse developers to use a buffered image as a double buffer (currently by means of
setting the corresponding property), because of the performance issue
But users may still want to have a shortcut to maximize a window in
case #3. How about we still allow for maximizing a window, but use its
maximum size instead of the maximized bounds as the size for a maximized
window? In other words, the maximum size (if set) has a precedence over
the
Hi.
Just my 2 cents. From my point of view the calls below looks similar
and should behave in the same way:
1 setMaximumSize/setMinimumSize + setBounds.
2 setMaximumSize/setMinimumSize + setMaximizedBounds+setMaximumState.
3 setMaximumSize/setMinimumSize + resize by the user.
4
Hello,
Please review my changes to address
8030845: Fix doclint missing issues in java.awt.event
in JDK 9. Webrev at
http://cr.openjdk.java.net/~darcy/8030845.0/
patch below.
Thanks,
-Joe
--- old/src/share/classes/java/awt/event/AWTEventListener.java
2013-12-19 21:48:44.0
11 matches
Mail list logo
