Hello AWT team,
Could you please review the fix for jdk9:
bug: https://bugs.openjdk.java.net/browse/JDK-8024061
webrev: http://cr.openjdk.java.net/~dmarkov/8024061/jdk9/webrev.00/
Problem description:
Dragging and dropping an object from one panel to another very quickly
causes an
Hello, Dmitry.
Thank you for the detailed explanation of the issue.
I’m OK with this workaround as this should be back ported to 8u and 7u, but I
think we could try to provide a real fix in 9.
Could you please add some comment which shortly explains why the if clause was
added?
And could you
Hi, Petr,
General comment:
Ugly parts of code (like 4, 5, 6, 7, 8) are just legacy of functional
tests. We will be trying to get rid of them.
See next version of webrev soon.
On 04/09/2014 02:24 PM, Petr Pchelko wrote:
Hello, Dmitriy.
1. Could you please not use the applet pattern in
Hi there,
this is friendly reminder about the review request.
Thanks,
Mikhail.
On 4/8/2014 6:03 PM, mikhail cherkasov wrote:
Hi again,
A regression test was added:
http://cr.openjdk.java.net/~mcherkas/8031075/webrev.01/
Could you please review second version of webrev?
Thanks,
Mikhail.
On
Hi,
Please, review the changeset for:
https://bugs.openjdk.java.net/browse/JDK-8039279
Webrev is here:
http://cr.openjdk.java.net/~yan/8039279/webrev.01/
Changelist:
1. Got rid of using applet in SetBounds test
2. Tests switched on using pattern throw RuntimeException on fail
3.
Not that I have something against this fix but
I feel it may be not necessary in future to use
SwingUtilities in all-AWT tests.
-yan
On 04/10/2014 03:03 PM, Dmitriy Ermashov wrote:
Hi,
Please, review the changeset for:
https://bugs.openjdk.java.net/browse/JDK-8039279
Webrev is here:
Hi Petr,
If the requested data flavor is DataFlavor.javaJVMLocalObjectMimeType,
then transferable is local to the JVM. It is stored to a static variable
in SunDropTargetContextPeer.setCurrentJVMLocalSourceTransferable(). When
processEnterMessage() is handled, its value is copied to instance
Hello, Alexey.
Thank you for the clarification.
What actually happens is that native drag-and-drop operation completed
already whereas this drag-and-drop operation on EDT didn't even started yet.
Does throwing InvalidDnDOperationException look more appropriate than
returning null in this
pls tell me how to quit this group?thanks
-- Original --
From: Henry Jen;henry@oracle.com;
Date: Thu, Apr 10, 2014 06:31 AM
To: Phil Racephilip.r...@oracle.com; Joe Darcyjoe.da...@oracle.com;
2d-dev2d-...@openjdk.java.net;
Cc:
Hi, Mikhail,
the fix looks fine.
The test looks fine as well, except the button field, which should be
volatile.
Thanks,
Artem
On 4/8/2014 6:03 PM, mikhail cherkasov wrote:
Hi again,
A regression test was added:
http://cr.openjdk.java.net/~mcherkas/8031075/webrev.01/
Could you please
Thank you!
On 4/10/2014 6:45 PM, Artem Ananiev wrote:
Hi, Mikhail,
the fix looks fine.
ok, will fix before commit.
The test looks fine as well, except the button field, which should
be volatile.
Thanks,
Artem
On 4/8/2014 6:03 PM, mikhail cherkasov wrote:
Hi again,
A regression test
The fix looks good.
I guess the test should be pushed to jdk 8,9 as well.
On 10.04.2014 18:49, mikhail cherkasov wrote:
Thank you!
On 4/10/2014 6:45 PM, Artem Ananiev wrote:
Hi, Mikhail,
the fix looks fine.
ok, will fix before commit.
The test looks fine as well, except the button
thank you for review!.
On 4/10/2014 8:13 PM, Sergey Bylokhov wrote:
The fix looks good.
I guess the test should be pushed to jdk 8,9 as well.
ok, Do I need to file a new bug or how it works for this case?
On 10.04.2014 18:49, mikhail cherkasov wrote:
Thank you!
On 4/10/2014 6:45 PM, Artem
13 matches
Mail list logo
