Hi Petr, Anthony,
Thank you for looking at this. I really missed the case pointed out by
Petr. If the test app is running in browser instead of IDE or
appletviewer, the situation is much worse - the opened popup does not
hide at all when we switch to another space. This behavior is caused by
Hello, Oleg.
Looks good.
With best regards. Petr.
On 14 мая 2014 г., at 19:02, Oleg Pekhovskiy oleg.pekhovs...@oracle.com wrote:
Hi Petr,
thank you for the review, here are my thoughts:
1. I added new method that way after analyzing the other methods and their
usage in jtreg tests. If
Hi, Oleg.
Thanks. The fix looks good.
On 14.05.2014 18:20, Oleg Pekhovskiy wrote:
Hi Sergey,
thanks you for comments!
Please review the second version of fix here:
http://cr.openjdk.java.net/~bagiras/9/8014755.2/
I've added re-throwing for catch blocks and commented System.exit()
calls that
Can I get another reviewer on this? I need a sponsor to push too.. (Anthony?)
-DrD-
src/solaris/native/sun/awt/awt.h
113 #if !defined(HEADLESS) defined(XAWT)
114 extern Display *awt_display; /* awt_GraphicsEnv.c */
You forgot to update this XAWT usage. Otherwise the fix looks
Ping!
Does this look OK?
I've also filed an issue against JavaFX:
https://javafx-jira.kenai.com/browse/RT-37125
-DrD-
I tried not modifying libpng but still ended up with lingering references
to longjmp in pngread.o, despite libpng having png_ptr-longjmp_fn (bug in
libpng?). pngread.c
Hello, David.
The fix looks good to me.
Artem was interested in the review, so we may want to wait for his final vote..
I can push the changeset for you. Please ping me when you decide it’s ready to
go.
Thank you.
With best regards. Petr.
On May 15, 2014, at 8:23 PM, David DeHaven
Approved.
-phil.
On 5/15/2014 9:31 AM, David DeHaven wrote:
Ping!
Does this look OK?
I've also filed an issue against JavaFX:
https://javafx-jira.kenai.com/browse/RT-37125
-DrD-
I tried not modifying libpng but still ended up with lingering references to
longjmp in pngread.o, despite
