Magnus:
Looks good to me as well.
Tim
On 03/04/15 05:31, Erik Joelsson wrote:
Hello,
Really nice to finally see this patch getting done!
Only one comment:
flags.m4:
In the grep expression, could you move the extra [] outside of the
actual command line options to grep so that the command
On 04/03/2015 15:03, Magnus Ihse Bursie wrote:
I believe all warnings are important to check! Unfortunately, this has
not been done for a lot of warnings for a lot of time. :(
Right, although in the past we had some areas close to be cleared of
warnings, it's just that we didn't keep up the
Hi Yuri,
the fix looks good to me too.
--
Thanks,
Alexander.
On 04.03.2015 16:28, Yuri Nesterenko wrote:
Hi!
Please review this fix for several regression tests.
Webrev: http://cr.openjdk.java.net/~yan/8074092/webrev.00
CR: https://bugs.openjdk.java.net/browse/JDK-8074092
In
On 03/04/2015 04:35 PM, Sergey Bylokhov wrote:
On 04.03.2015 15:51, Alan Bateman wrote:
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public
Hi,
@library ../../regtesthelpers
@library ../../../../lib/testlibrary
can be replaced with
@library /javax/swing/regtesthelper
@library /lib/testlibrary
Library path is concatenated to the directory in which TEST.ROOT is located.
Andrei Eremeev
On 03/04/2015 04:28 PM, Yuri Nesterenko
I like the overall approach.
We can then attack the warnings lib by lib and/or platform by platform.
I do want to mention that some libs like liblcms are 3rd party open
source libraries
and it may not always be possible to convince upstream to change their code.
-phil.
On 03/04/2015 08:30
On 04.03.2015 16:33, Semyon Sadetsky wrote:
Sergey,
OK. You can file a request to improve TrayIcon test coverage but it's
an another story. Here we are discussing regression test for a
specific bug.
I cannot agree with the approach you've proposed. In your logic we
need start to write
Yes, Andrei, you are right.
Starting from the next time (perhaps it will be a bulk
test update for Jigsaw) we'll use this notation.
Thank you!
-yan
On 03/04/2015 06:58 PM, andrei.eremeev wrote:
Hi,
@library ../../regtesthelpers
@library ../../../../lib/testlibrary
can be replaced with
Hi, Semyon.
I suggest to remove stuff related to windows platform from the test.
Also it will be good to test some reasonable range of data instead of
magic constant, wrap setTooltip/displayMessage in a loop.
Please add tray.remove(trayIcon); at the end of the test, otherwise it
can hang, when
Thanks, Sergey!
tray.remove at the end is accepted.
Below is about your proposal to run reg test on all other platforms and
scan parameters lengths:
--
I think it's more like bug regression test policy. Since I'm a novice in
the project maybe you or somebody can advise me the right process.
Hi,Alexander.
The fix looks fine.
On 02.03.2015 18:47, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8056151/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8056151
There are several prerequisites for this crash:
enabled XRender
On 04.03.2015 15:08, Semyon Sadetsky wrote:
I think it's more like bug regression test policy. Since I'm a novice
in the project maybe you or somebody can advise me the right process.
Lets see what we have here:
The fix is connected to the windows platform native code only. It is a
platform
Hi, Nakul.
Thanks for the fix.
A few notes:
- Please remove the bugid information from the comment since we have
mercurial history for such notes.
- I suppose that the comment can be shorter, like this: We need an up
to date size of the peer, so we flush the native events to be sure that
When building the native code in the jdk repo, a lot of warnings are
generated. So many that it's hard to spot any new issues.
While the ultimate goal must be to address and fix these warnings
individually, this bug is about disabling these warnings where they
occur, so that it is easier to
Hello,
Really nice to finally see this patch getting done!
Only one comment:
flags.m4:
In the grep expression, could you move the extra [] outside of the
actual command line options to grep so that the command line could be
copied to the shell for debugging in the future? Also, how hard
Sergey,
OK. You can file a request to improve TrayIcon test coverage but it's an
another story. Here we are discussing regression test for a specific bug.
I cannot agree with the approach you've proposed. In your logic we need
start to write regression tests for all methods in JDK classes those
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public java.awt.Font.getPeer() @deprecated 1.1
public
Hi, Yuri.
The fix looks good.
On 04.03.2015 16:28, Yuri Nesterenko wrote:
Hi!
Please review this fix for several regression tests.
Webrev: http://cr.openjdk.java.net/~yan/8074092/webrev.00
CR: https://bugs.openjdk.java.net/browse/JDK-8074092
In bug8062561.java test an error message also
On 04/03/2015 13:17, Magnus Ihse Bursie wrote:
:
I intend to file individual bugs to handle these remaining warnings,
so the net result will be a completely warning free build.
I also intend to file individual bugs on all the libraries that has
had warnings disabled. I expect the outcome of
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public java.awt.Font.getPeer() @deprecated 1.1
public java.awt.MenuComponent.getPeer() @deprecated 1.1
There is
Hi!
Please review this fix for several regression tests.
Webrev: http://cr.openjdk.java.net/~yan/8074092/webrev.00
CR: https://bugs.openjdk.java.net/browse/JDK-8074092
In bug8062561.java test an error message also changed.
Verified on 3 platforms.
Thanks,
-yan
On 04.03.2015 15:51, Alan Bateman wrote:
On 04/03/2015 12:37, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 9.
There are a number of public API whichreference the unsupported
java.awt.peer interfaces.
public java.awt.Component.getPeer() @deprecated 1.1
public
the updated webrev:
http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.04/
On 3/4/2015 4:33 PM, Semyon Sadetsky wrote:
Sergey,
OK. You can file a request to improve TrayIcon test coverage but it's
an another story. Here we are discussing regression test for a
specific bug.
I
On 2015-03-04 14:48, Alan Bateman wrote:
On 04/03/2015 13:17, Magnus Ihse Bursie wrote:
:
I intend to file individual bugs to handle these remaining warnings,
so the net result will be a completely warning free build.
I also intend to file individual bugs on all the libraries that has
had
24 matches
Mail list logo
