Re: AWT Dev [9] Review Request: 8074757 Remove java.awt.Toolkit methods which return peer types

2015-04-03 Thread Phil Race
On 04/03/2015 10:15 AM, Sergey Bylokhov wrote: 03.04.15 19:59, Phil Race wrote: HeadlessToolkit.java 321 @Override 322 @SuppressWarnings(deprecation) === We don't need this any more do we ? 323 public FontPeer getFontPeer(String name, int style) { 324 if

Re: AWT Dev [9] Review Request: 8074757 Remove java.awt.Toolkit methods which return peer types

2015-04-03 Thread Alan Bateman
On 02/04/2015 16:15, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public methods in the java.awt.Toolkit class, which reference the unsupported java.awt.dnd.peer and java.awt.peer interfaces. There is a decision to remove these references as

Re: AWT Dev [9] Review Request for 8074807: Fix some tests unnecessary using internal API

2015-04-03 Thread Phil Race
http://cr.openjdk.java.net/~yan/8074807/webrev.diff.00/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html.sdiff.html I find it very weird to add copyright 2015 just when adding the license header that contains the copyright ! -phil. On 03/17/2015 04:28 AM, Yuri

Re: AWT Dev RfR JDK-8055160

2015-04-03 Thread Pete Brunet
Due to the recent push of JDK-8076182 (Open source Java Access Bridge) which exposed some files that were in closed the webrev needs a full re-review. I've also made the changes requested by Mandy. http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.02/ Pete On 3/23/15 4:41 PM, Mandy Chung

Re: AWT Dev RfR JDK-8055160

2015-04-03 Thread Mandy Chung
On 4/3/2015 1:59 PM, Pete Brunet wrote: Due to the recent push of JDK-8076182 (Open source Java Access Bridge) which exposed some files that were in closed the webrev needs a full re-review. I've also made the changes requested by Mandy.