Re: [9] Review Request: 8015900 [TEST_BUG] ScrollbarMouseWheelTest failed on ubuntu 12 with unity and unity 2D

2015-05-07 Thread Alexander Zvegintsev
Hello Sergey, the fix looks good to me. Thanks, Alexander. On 07/05/15 18:29, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test has incorrect assumption that the new window usually opens in the top-left corner of the window, and moves the robot according this assumption.

[9] Review Request: 8015900 [TEST_BUG] ScrollbarMouseWheelTest failed on ubuntu 12 with unity and unity 2D

2015-05-07 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. The test has incorrect assumption that the new window usually opens in the top-left corner of the window, and moves the robot according this assumption. - This assumption was fixed via getLocationOnScreen - Unnecessary stuff were removed - Test was move

Re: [9-dev] Review request for bug 8079440 : [TESTBUG] @run is missing in java/awt/TrayIcon/8072769/bug8072769.java

2015-05-07 Thread Alexander Zvegintsev
Hi, the bug8072769.java looks fine to me. Path2DCopyConstructor.java is already fixed by [1]. [1] https://bugs.openjdk.java.net/browse/JDK-8078464 Thanks, Alexander. On 05/06/2015 01:37 PM, shobhit gupta wrote: |Hi,| |Please review a fix ||for| |the issue:| JDK-8079440 : [TESTBUG] @run is m

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

2015-05-07 Thread Semyon Sadetsky
Hi Sergey, Yes, after the fix filedialog produces usual filesystem paths for libraries which are readable for java.io. But there are no possibility to reference files in libraries directly using new File(). --Semyon On 5/7/2015 11:26 AM, Sergey Bylokhov wrote: Hi, Semyon. Can you please rai

Re: [9] Review request for 8079255 [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

2015-05-07 Thread Sergey Bylokhov
Hi, Alexander. Please dispose the frame at the end of the test. Also please update the first date in the copyright. It is interesting to think about a public api for mouse_wheel rotation direction. On 07.05.15 12:44, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https:

[9] Review request for 8079255 [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

2015-05-07 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8079255 webrev: http://cr.openjdk.java.net/~alexsch/8079255/webrev.00 The test does not take into account that the MouseWheelEvent.getWheelRotation() has reversed value on Mac OS X. The test is updated and

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

2015-05-07 Thread Sergey Bylokhov
Hi, Semyon. Can you please raise the supportness of this in the java.io on the core-libs alias. Does the open filedialog will work after the fix? On 07.05.15 11:14, Semyon Sadetsky wrote: Hello, Please review fix for JDK9. webrev: http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.00/ bug:

[9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

2015-05-07 Thread Semyon Sadetsky
Hello, Please review fix for JDK9. webrev: http://cr.openjdk.java.net/~ssadetsky/8003399/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8003399 ***THE ROOT CAUSE JDK uses legacy WINAPI special folders calls while MS introduced a new interfaces IKnownFolder and IShellLibrary to manage