Re: [OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: "no parameter" in 2d source code

I did not slog through all the webrev again but the changed parts look good, so "+1". -phil. On 5/8/15 3:34 PM, Sergey Bylokhov wrote: Hi, Phil. Thanks for a review! The new version: http://cr.openjdk.java.net/~serb/6587235/webrev.01 On 08.05.15 22:52, Phil Race wrote: 273 * RuntimePermissio

Re: [9] Review Request: 8071306 GUI perfomance are very slow compared java 1.6.0_45

Hi, Anton. On 08.05.15 12:23, Anton V. Tarasov wrote: 1314 /** 1315 * Determines the bounds which will be displayed on the screen. 1316 * 1317 * @return the visible part of bounds in the coordinate space of this comp 1318 */ 1319 private Rectangle getRecursivelyVisi

Re: [OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: "no parameter" in 2d source code

Hi, Phil. Thanks for a review! The new version: http://cr.openjdk.java.net/~serb/6587235/webrev.01 On 08.05.15 22:52, Phil Race wrote: 273 * RuntimePermission("accessClassInPackage."+pkg) 274 * permission. 275 * 276 * @param pkgname the package name. perhaps line 273 s

Re: [OpenJDK 2D-Dev] [9] Review Request: 6587235 Incorrect javadoc: "no parameter" in 2d source code

273 * RuntimePermission("accessClassInPackage."+pkg) 274 * permission. 275 * 276 * @param pkgname the package name. perhaps line 273 should match ? 7 * @param srcArg The first source tile for the compositing operation. 88 * @param dstIn The second sourc

Re: RfR JDK-8078408, Java version applet hangs with Voice over turned on

Resending to correct list... On 5/8/15 2:11 PM, Pete Brunet wrote: > Please review the fix for JDK-8078408 "Java version applet hangs with > Voice over turned on". > > The failure is an NPE. There is a variable that is OK to be null at the > point of failure and the fix adds a check for it being

[9] Review Request: 6587235 Incorrect javadoc: "no parameter" in 2d source code

Hello. Please review the fix for a typos in jdk9. This CR was filed by me long time ago and I doubt that someone will take a look at it. I fixed all clients files in sun.** subpackages. Bug: https://bugs.openjdk.java.net/browse/JDK-6587235 Webrev can be found at: http://cr.openjdk.java.net/~ser

[9] Review request for 8068886: IDEA IntelliJ crashes in objc_msgSend when an accessibility tool is enabled

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8068886/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8068886 Problem: t

Re: [9] Review request for 8079255 [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Hi, Alexander. Looks fine to me. On 08.05.15 16:44, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8079255/webrev.01/ - the first date is added to the copyright - the frame is disposed Thanks, Alexandr. On 5/7/2015 1:29 P

[9] Review request for 8078606: Deadlock in awt clipboard

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8078606/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8078606 Problem: XClipboard sometimes deadlocked Reason: XClipbo

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

On 5/8/2015 3:45 PM, Sergey Bylokhov wrote: On 07.05.15 15:29, Semyon Sadetsky wrote: Hi Sergey, Yes, after the fix filedialog produces usual filesystem paths for libraries which are readable for java.io. Just to clarify: after the fix, both Open and Save dialog works? Open file in library w

Re: [9] Review request for 8079255 [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8079255/webrev.01/ - the first date is added to the copyright - the frame is disposed Thanks, Alexandr. On 5/7/2015 1:29 PM, Sergey Bylokhov wrote: Hi, Alexander. Please dispose the frame at the end of t

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

On 07.05.15 15:29, Semyon Sadetsky wrote: Hi Sergey, Yes, after the fix filedialog produces usual filesystem paths for libraries which are readable for java.io. Just to clarify: after the fix, both Open and Save dialog works? But there are no possibility to reference files in libraries directl

Re: [9] Review request for 8065739 [macosx] Frame warps to lower left of screen when displayed

Hi, Alexander. Does the new tests cover all corner cases which we discussed offline? On 08.05.15 15:28, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8065739/webrev.03 - The -windowWillUseStandardFrame:defaultFrame: method is i

Re: [9] Review request for 8065739 [macosx] Frame warps to lower left of screen when displayed

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8065739/webrev.03 - The -windowWillUseStandardFrame:defaultFrame: method is implemented in AWTWindow to correctly get and check a size of the maximized window. After that the -isZoomed method correctly defin

Re: [9] Review request for 8003399: JFileChooser gives wrong path to selected file when saving to Libraries folder on Windows 7

Hi Semyon, Some comments: - Please, correct the name to KnownfolderDefinition, or better KnownFolderDefinition: +static class KnownfolderDefenition { - Should JNI exceptions be asserted in Java_sun_awt_shell_Win32ShellFolder2_loadKnownFolders? Regards, Anton. On 07.05.2015 11:14, Semyo

Re: [9] Review Request: 8071306 GUI perfomance are very slow compared java 1.6.0_45

Hi Sergey, The perf improvment is great! I have some minor comments only: 1. 1314 /** 1315 * Determines the bounds which will be displayed on the screen. 1316 * 1317 * @return the visible part of bounds in the coordinate space of this comp 1318 */ 1319 private Recta

Re: [9] Review Request: 8015900 [TEST_BUG] ScrollbarMouseWheelTest failed on ubuntu 12 with unity and unity 2D

Hi Sergey, fine with me. BTW will it work on the multimonitor OS X configuration:-)? -yan On 05/07/2015 06:29 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test has incorrect assumption that the new window usually opens in the top-left corner of the window, and moves t