On 13.07.15 16:59, Semyon Sadetsky wrote:
Yet another issue I found in the GTK file chooser code is a dispose
concurrency issue. The GTK dialog widget is being created in a
separate thread upon the setVisible(true) call but it can be hidden or
disposed without any synchronization with this
Hi, Pete.
The fix looks fine, but you should tweak the test a little bit.
- You access the swing components on non-EDT thread.
- You should not use System.exit in the test.
- The JFrame should be disposed before the end of the test.
On 14.07.15 1:34, Pete Brunet wrote:
Please review the
Small comment:
GtkFileDialogPeer.c: you will need to add a CHECK_NULL( widgetFieldID)
before setWindowMethodID, and CHECK_NULL(setWindowMethodID); at the end
of the method is not necessary.
On 13.07.15 16:59, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug:
This is concurrency issue. Such test would be unstable or take a lot of
time.
On 7/14/2015 1:08 PM, Sergey Bylokhov wrote:
On 13.07.15 16:59, Semyon Sadetsky wrote:
Yet another issue I found in the GTK file chooser code is a dispose
concurrency issue. The GTK dialog widget is being created in
On 14.07.15 14:16, Semyon Sadetsky wrote:
This is concurrency issue. Such test would be unstable or take a lot
of time.
I guess after the fix it should be stable? or there are some other issues?
On 7/14/2015 1:08 PM, Sergey Bylokhov wrote:
On 13.07.15 16:59, Semyon Sadetsky wrote:
Yet
The fix is stable.
On 7/14/2015 3:02 PM, Sergey Bylokhov wrote:
On 14.07.15 14:16, Semyon Sadetsky wrote:
This is concurrency issue. Such test would be unstable or take a lot
of time.
I guess after the fix it should be stable? or there are some other
issues?
On 7/14/2015 1:08 PM, Sergey
looks good to me too.
Thanks,
Alexander.
On 07/08/2015 11:50 AM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/6/2015 5:33 PM, Semyon Sadetsky wrote:
Transitivity (2) violated:
X:
You don't need to add the /secure option to jtreg. That's overriding
jtreg's SecurityManager and causing you to have to grant jtreg
permissions to read files in the jtreg.security.policy file. Just add
the /java.security.policy option -- this will use jtreg's
SecurityManager which is
Moving the internal classes to com.sun.java.accessibility.internal is right as
com.sun.java.accessibility is a supported API. Sean is right that no need to
specify /secure=java.lang.SecurityManager.
Mandy
On Jul 14, 2015, at 11:57 PM, Sean Mullan sean.mul...@oracle.com wrote:
You don't
