Re: AWT Dev [9] Review request for 8014212: Robot captures black screen

2015-07-23 Thread Sergey Bylokhov
Hi, Alexander. I am not sure that an assumption that we should not make a screen shot if the x and y are negative is correct. I guess that we should take a screenshot of the intersection of the requested area and the display. Can you also check this comment in the TranslucentJAppletTest.java:

Re: AWT Dev [8u-dev] Review request for 8130776: Remove EmbeddedFrame.requestFocusToEmbedder() method

2015-07-23 Thread Anton V. Tarasov
Looks fine to me. Regards, Anton. On 23.07.2015 17:09, Alexey Ivanov wrote: Hello AWT team, Could you please review the backport of JDK-8130776 to jdk8u-dev: http://cr.openjdk.java.net/~aivanov/8130776/jdk8/webrev.00/ The patch from JDK9 does not apply cleanly because of different mechanism

AWT Dev [8u-dev] Review request for 8130776: Remove EmbeddedFrame.requestFocusToEmbedder() method

2015-07-23 Thread Alexey Ivanov
Hello AWT team, Could you please review the backport of JDK-8130776 to jdk8u-dev: http://cr.openjdk.java.net/~aivanov/8130776/jdk8/webrev.00/ The patch from JDK9 does not apply cleanly because of different mechanism to access peer in WEmbeddedFrame.java. Logically there are no changes.

AWT Dev [9] Review request for 8014212: Robot captures black screen

2015-07-23 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8014212 This fix trying to use gdk_pixbuf_get_from_drawable () [0] to capture screenshot(basic image data handling could be found here[1]). If it fails

Re: AWT Dev [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-07-23 Thread Jim Graham
Hi Alexandr, On 7/21/15 7:41 AM, Alexander Scherbatiy wrote: Hello Jim, Thank your for the review. Could you review the updated fix there the suggested comments are updated: http://cr.openjdk.java.net/~alexsch/8029339/webrev.09/ Minor comments embedded below. On 7/14/2015

AWT Dev Awt Dev [9] Review Request for 8130471: [Regression] Test java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java fails

2015-07-23 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130471 webrev: http://cr.openjdk.java.net/~ssadetsky/8130471/webrev.00/ This is a regression from 8041470 in which mouse event modifiers was changed for all wheel events including button click event. That caused

Re: AWT Dev [9] Review request for 8131752 [Regression] Test java/awt/GraphicsDevice/CheckDisplayModes.java fails

2015-07-23 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/22/2015 7:07 PM, Alexander Zvegintsev wrote: Hello, Please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8131752/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8131752 This fix simply restores fullscreen windows