Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

2015-10-19 Thread mikhail cherkasov
Hi there, http://cr.openjdk.java.net/~mcherkas/8136763/webrev.02/ During adding the test, I've mistakenly returned flavormap version with removed "text/uri-list". Now "text/uri-list" is in place again. Thanks, Mikhail. On 10/15/2015 11:42, mikhail cherkasov wrote: Hi Sergey, Alexander,

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

2015-10-19 Thread Sergey Bylokhov
The fix looks fine. please fix the typo "returens" in CDataTransferer before the push. On 19.10.15 10:39, mikhail cherkasov wrote: Hi there, http://cr.openjdk.java.net/~mcherkas/8136763/webrev.02/ During adding the test, I've mistakenly returned flavormap version with removed

[9] Review Request for 8139227: Text fields in JPopupMenu structure do not receive focus in hosted Applets

2015-10-19 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8139227 webrev: http://cr.openjdk.java.net/~ssadetsky/8139227/webrev.00/ Win32 window owner query returns the browser frame for applet's child window because there are no any other overlapped or popup windows on

Re: [9] Review request for: 8136763 [macosx] java always returns only one value for "text/uri-list" dataflavor even if several files were copied

2015-10-19 Thread mikhail cherkasov
Sergey, thank you. Alexander , could you please review the fix too? Thanks, Mikhail. On 10/19/2015 13:51, Sergey Bylokhov wrote: The fix looks fine. please fix the typo "returens" in CDataTransferer before the push. On 19.10.15 10:39, mikhail cherkasov wrote: Hi there,

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-19 Thread Ambarish Rapte
Hi Alexander, In single line mode , there is no rich edit control style to handle EOL. Referenced documentation: https://msdn.microsoft.com/en-us/library/windows/desktop/bb787605(v=vs.85).aspx Many Thanks Ambarish -Original Message- From: Alexander Scherbatiy Sent:

Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

2015-10-19 Thread Sergey Bylokhov
On 15.10.15 9:57, Semyon Sadetsky wrote: - Why did you add a check to the new constructor of FocusEvent? This check should be done already in the EventObject, and executes before your new check? Is it a typo and it should be cause? When why do not throw an NPE? The test should verify this also.

Re: [9] Review Request for 8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9

2015-10-19 Thread Sergey Bylokhov
On 18.09.15 18:50, Semyon Sadetsky wrote: Why do you think so? Each app context KFM has own keystrokes if it is initialized from the thread that belongs to its ThreadGroup. Sorry. I see what you mean. That is corrected as well: http://cr.openjdk.java.net/~ssadetsky/8130895/webrev.02/ After