Re: [9] Review Request: 8138764 In some cases the usage of TreeLock can be replaced by other synchronization

2015-10-20 Thread Alexander Potochkin
Hello Sergey The fix looks good. (It was very useful to discuss it in person) Thanks alexp On 10/6/2015 17:09, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9, I plan to backport it to jdk8. In this fix some of synchronizations on TreeLock were removed. - Component.java(CachedPa

Re: [9] Review Request for 8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9

2015-10-20 Thread Sergey Bylokhov
On 20.10.15 13:33, Semyon Sadetsky wrote: On 10/19/2015 8:12 PM, Sergey Bylokhov wrote: On 18.09.15 18:50, Semyon Sadetsky wrote: Why do you think so? Each app context KFM has own keystrokes if it is initialized from the thread that belongs to its ThreadGroup. Sorry. I see what you mean. Tha

Re: [9] Review Request for 8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9

2015-10-20 Thread Semyon Sadetsky
On 10/19/2015 8:12 PM, Sergey Bylokhov wrote: On 18.09.15 18:50, Semyon Sadetsky wrote: Why do you think so? Each app context KFM has own keystrokes if it is initialized from the thread that belongs to its ThreadGroup. Sorry. I see what you mean. That is corrected as well: http://cr.openjdk.j

Re: RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application(macos)

2015-10-20 Thread Alexander Scherbatiy
On 10/13/2015 10:32 PM, Sebastian Sickelmann wrote: On 10/08/2015 01:06 PM, Alexander Scherbatiy wrote: Are you going to push the fix as part of other fixes for different JDK areas or as a separate fix? In the second case you need to file a new bug for it. I think the patches in the othe

Re: [awt-dev] Request for Approval and Review: JDK-8136592 [TEST_BUG] Fix 2 platform-specific closed regtests for jigsaw

2015-10-20 Thread Yuri Nesterenko
OK, +1. -yan On 10/05/2015 12:43 PM, Renjith Alexander wrote: Hi All, Please find the updated webrev at: http://cr.openjdk.java.net/~pchopra/8136592/webrev.01/ Regards, Renjith. -Original Message- From: Yuri Nesterenko Sent: Wednesday, September 30, 2015 5:20 PM To: Renjith Alexande

Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

2015-10-20 Thread Semyon Sadetsky
On 10/19/2015 8:41 PM, Sergey Bylokhov wrote: On 15.10.15 9:57, Semyon Sadetsky wrote: - Why did you add a check to the new constructor of FocusEvent? This check should be done already in the EventObject, and executes before your new check? Is it a typo and it should be cause? When why do not th