Re: [9] Review Request for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

2015-10-29 Thread Semyon Sadetsky
On 10/29/2015 12:20 AM, Sergey Bylokhov wrote: On 06.10.15 9:15, Semyon Sadetsky wrote: Sorry. I meant it is not guaranteed to be sent by every WM. But fetch the data of 100 times also doesn't guarantee that we will get the necessary data. It will be better at least to try to check

Re: [9] Review request for 8132503: [macosx] Chinese full stop symbol cannot be entered with Pinyin IM on OS X

2015-10-29 Thread Anton Litvinov
Hello Alexander, Thank you for review of this fix. Responses to your questions are following. 1) I also was not able to find any methods available in "java.lang.Character", "java.lang.Character.UnicodeBlock", "java.lang.Character.Subset" classes or API in Cocoa which would allow to get

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-29 Thread Ambarish Rapte
Hi Alexandr, Please review the updated webrev, with changes only in TextField.java. Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.01/ replaceEOL() is declared static, as a class member method cannot be called before call to super from

Re: [9] Review request for 8132503: [macosx] Chinese full stop symbol cannot be entered with Pinyin IM on OS X

2015-10-29 Thread Alexander Scherbatiy
On 10/29/2015 7:08 PM, Anton Litvinov wrote: Hello Alexander, The second version of the fix, which addresses your suggestion concerning introduction of a separate method checking, if the "unichar" belongs to certain Unicode blocks, was created. For this purpose the method "-(BOOL)

Re: [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

2015-10-29 Thread Sergey Bylokhov
On 17.07.15 16:27, Alexander Scherbatiy wrote: - Sergey's point about multi-mon should be checked out. Windows 8.1 has option "Let me choose one scaling level for all my displays". If I unset it I am able to change the size of all items. However, the DPI which returns

Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

2015-10-29 Thread Ambarish Rapte
Dear All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8048171 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/ambarish/8048171/webrev.00/"http://cr.openjdk.java.net/~rchamyal/ambarish/8048171/webrev.00/

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-29 Thread Ambarish Rapte
Hi Sergey, The webrev is updated with using System.lineSeparator() instead of System.getProperty("line.separator"). Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.01/ Reason for using array: System.lineSeparator() differs platform

Re: Review Request for 8055197: TextField deletes multiline strings

2015-10-29 Thread Alexander Scherbatiy
On 10/29/2015 5:31 PM, Ambarish Rapte wrote: Hi Alexandr, Please review the updated webrev, with changes only in TextField.java. Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.01/ replaceEOL() is declared static, as a class member method cannot

Re: [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

2015-10-29 Thread Phil Race
size->cx = (int)ceil(size->cx / scale); So if size->cx / scale works out to be 12.0001 you will round it up to 13? Can you check what pixel size windows gives you in such a case ? I'd be a little surprised if they did that rather than round. Is the SetFontProperty that does not accept a scale

Re: [9] Review request for 8132503: [macosx] Chinese full stop symbol cannot be entered with Pinyin IM on OS X

2015-10-29 Thread Alexander Zuev
Anton, this version looks fine to me. /Alex On 29/10/15 19:08, Anton Litvinov wrote: Hello Alexander, The second version of the fix, which addresses your suggestion concerning introduction of a separate method checking, if the "unichar" belongs to certain Unicode blocks, was created. For