Re: Review request for 8139508 Debug option does not work in appletviewer

2016-02-01 Thread Phil Race
Approved, but remember you also need an approved CCC before committing this change. -phil. On 01/25/2016 04:56 AM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8139508 webrev:

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

2016-02-01 Thread Jim Graham
Hi Alexandr, In awt_DesktopProperties.cpp you are using the Y scaling factor to scale widths still - see lines 287 (and others in that same function) and then 322 in another function. It looks like you'll need getInvScaleX() and getInvScaleY(). I'll leave it to Phil to comment on the unit

Review Request for 8025001: setFocusTraversalPolicy() to ContainerOrderFocusTraversalPolicy results in an infinite loop

2016-02-01 Thread Ambarish Rapte
Hi All, Please review the fix for jdk9, Bug: https://bugs.openjdk.java.net/browse/JDK-8025001 Webrev: http://cr.openjdk.java.net/~arapte/8025001/webrev.00/ Issue: ContainerOrderFocusTraversalPolicy.getComponentAfter() returns the same

Re: Should TextField Documentation be updated ?

2016-02-01 Thread Alexandr Scherbatiy
What is behavior of text controls on different OSes (Windows, Linux, Mac OS X)? Is new line character is replaced to to a space, preserved, or the text is truncated? Thanks, Alexandr. On 1/28/2016 3:19 AM, Ambarish Rapte wrote: Hi, If the input string contains new line character,

Re: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

2016-02-01 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/28/2016 9:45 PM, Prem Balakrishnan wrote: Hi*,* Please review fix for JDK9, *Bug: *https://bugs.openjdk.java.net/browse/JDK-8062946** *Webrev: *http://cr.openjdk.java.net/~arapte/prem/8062946/webrev.00/

Re: Review request for 8005918 : [TESTBUG] There are no 'Frame Enter' messages for both frames, only 'Button Enter' message.

2016-02-01 Thread Ajit Ghaisas
Hi, Good suggestion. I have rewritten the test as not to use applet. Also, I have converted manual test to automated one. The changes can be found in : http://cr.openjdk.java.net/~arapte/ajit/8005918/webrev.01/ Please review. Regards, Ajit From:

Re: [OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L on Win 8.1 with HiDPI display

2016-02-01 Thread Alexandr Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8076545/webrev.04/ - both LOGPIXELSX and Y are used for the theme size scaling. - LOGPIXELSY is used for text metrics height rescaling Thanks, Alexandr. On 1/29/2016 1:16 PM, Jim Graham wrote: Hi Alexandr, Thanks

Re: Should TextField Documentation be updated ?

2016-02-01 Thread Ambarish Rapte
Hi Alexandr, Label, JTextField, JLabel: On All platforms, replace the new line character by space character. TextField: On Linux And MacOSX, replace the new line character by space character. But only on Windows, TextField terminated string after

Re: Should TextField Documentation be updated ?

2016-02-01 Thread Alexandr Scherbatiy
On 2/1/2016 4:26 AM, Ambarish Rapte wrote: Hi Alexandr, Label, JTextField, JLabel: On All platforms, replace the new line character by space character. I meant native controls behavior like Rich Edit on Windows or NSTextField on Mac OS X. Thanks, Alexandr. TextField: On

Re: Review request for 8139508 Debug option does not work in appletviewer

2016-02-01 Thread Semyon Sadetsky
Looks good to me. --Semyon On 1/25/2016 3:56 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8139508 webrev: http://cr.openjdk.java.net/~alexsch/8139508/jdk9-client/webrev.00 The appletviewer debug support is removed.

Re: [9] Review request for 8139581: AWT components are not drawn after removal and addition to a container

2016-02-01 Thread Anton Litvinov
Hello Semyon, Thank you for review of this fix. This issue depends on race conditions. In fact this issue is reproducible sometimes also, when the components are initially added to the container, thus removal with further addition of the components is not the only scenario of this bug. In the