Re: Review Request for 6211389: Window.getMostRecentFocusOwner() returns null

Hi Prem, Component cannot become a global focus owner before it receives the focus gained event. Did you try to run focus reg tests with your fix? --Semyon On 2/29/2016 10:03 AM, Prem Balakrishnan wrote: Hi*,* Please review fix for JDK9, *Bug:

Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

The fix looks fine. Small notes about the test: - Probably it will be better to increase the height of the instruction to eliminate the vertical scroll? - The typo: 67 "Mouse press on te TextField text", On 11.02.16 12:23, Ambarish Rapte wrote: Hi, Please review the fix

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

Please see JDK-8150844 On 2/29/2016 6:52 PM, Sergey Bylokhov wrote: On 29.02.16 18:45, Alexander Stepanov wrote: not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an enhancement bug should be created). So for OS X now we have only single test run in fact. I

Re: [9] Review Request: 8144164 [macosx] Test java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest failed

On 29.02.16 18:49, Yuri Nesterenko wrote: Hi Sergey, fix looks OK to me. We didn't see the original issue on Mac, did we? It was fixed long time ago before osx-port in jdk6. So on OSX, I just tries to check something similar to what we do on other platforms instead of excluding the test for

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

On 29.02.16 18:45, Alexander Stepanov wrote: not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an enhancement bug should be created). So for OS X now we have only single test run in fact. I do not remember that such request was filed, please file a separate

Re: [9] Review Request: 8144164 [macosx] Test java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest failed

Hi Sergey, fix looks OK to me. We didn't see the original issue on Mac, did we? Thanks, -yan On 02/28/2016 10:33 PM, Sergey Bylokhov wrote: Hello, Please review the small fix for jdk9. The test tries to use Alt+F4 but it is meaningless on OSX. - On OSX Ctrl+f4 (cycle between open windows in

[9] Review Request for 8150535: [TEST_BUG] fix @library for test/java/awt/TrayIcon/MouseMovedTest/MouseMovedTest.java

Colleagues, please review this test-only fix for some tray icon AWT tests in 9-jigsaw repository. CR is https://bugs.openjdk.java.net/browse/JDK-8150535 Webrev: http://cr.openjdk.java.net/~yan/8150535/webrev.00 The fix should go to 9-jigsaw since there are extra lines using Xpatch (comparing

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

The following version of the test passes for OS X + retina (as well as for Windows and Linux): http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/ not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an enhancement bug should be created). So for OS X now we

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

Hello Sergey, When running the following trivial test case (having Color set to "Generic RGB Profile") import java.awt.*; public class ColorTest extends Frame { private void UI() { setSize(100, 100); setBackground(Color.BLUE); setVisible(true); } public

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

Hello Sergey, Thank you for the note; Could you please review the fix for this issue http://cr.openjdk.java.net/~avstepan/8150643/webrev.02/ If the changes are appropriate then I'll create a separate test bug and push them. Thanks, Alexander On 2/26/2016 8:34 PM, Sergey Bylokhov wrote:

Re: [9] Review request for JDK-8145174 HiDPI splash screen support on Linux

On 2/23/2016 12:41 PM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. I have updated the webrev as per review comments. Webrev : http://cr.openjdk.java.net/~rchamyal/8145174/webrev.01/ - splashscreen_sys.c Is