Re: [9] Review Request: 8154088 [macosx] SWT does not work on JDK 9 since b65

2016-04-12 Thread Phil Race
+1 -phil. On 04/12/2016 04:15 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. The root cause of the problem is that the peer is initialized and validated on the different threads. SWT calls addNotify() on EDT and validateWithBounds() on the Main thread. The bug was found

[9] Review Request: 8154088 [macosx] SWT does not work on JDK 9 since b65

2016-04-12 Thread Sergey Bylokhov
Hello, Please review the fix for jdk9. The root cause of the problem is that the peer is initialized and validated on the different threads. SWT calls addNotify() on EDT and validateWithBounds() on the Main thread. The bug was found when I worked on JDK-8148109 [1] In the fix of JDK-8074028

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

2016-04-12 Thread Semyon Sadetsky
Hi Manajit, The fix itself is OK. Why the test cannot be automated? --Semyon On 4/12/2016 1:46 PM, Manajit Halder wrote: Hi All, Gentle remainder. Please review the changes. Thanks, Manajit On 07-Apr-2016, at 1:48 pm, Manajit Halder

Re: Public RequestFocusController/AWTAccessor API

2016-04-12 Thread Reto Merz
Hello Alexandr, Basically we need to detect and intercept focus changes. java.awt.Component allows to override this methods: requestFocus() requestFocus(boolean) requestFocusInWindow() requestFocusInWindow(boolean) requestFocus() is only invoked when the component is focused by a mouse click.

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

2016-04-12 Thread Manajit Halder
Hi All, Gentle remainder. Please review the changes. Thanks, Manajit > On 07-Apr-2016, at 1:48 pm, Manajit Halder wrote: > > Hi All, > > Kindly review the fix for JDK9. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8151136 >

Re: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

2016-04-12 Thread Ramesh Gangadhar
Hello, Please review bug fix for 8027154 bug: https://bugs.openjdk.java.net/browse/JDK-8027154 Webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.02/ Issue: mouseMoved(MouseEvent) recieves sometimes position as [29,29] and sometimes as [30,30] from AWT native code