Hi Ambarish,
Fix looks ok to me.
Regarding test, the copyright should be changed to 2016. Also, the
initial bugid is missing, since you added bugid can you probably add the
initial bugid too?
Please change the wildcard imports to specific imports.
Did you test in oel too? The test is skipped
Hello All,
This is a gentle remainder for review.
Best Regards,
Ramesh BG
From: Ramesh Gangadhar
Sent: Thursday, April 14, 2016 19:40
To: awt-dev@openjdk.java.net
Subject: Re: Review Request For 8129569 : Test
java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails
Hello All,
This is a gentle remainder for review.
Best Regards,
Ramesh BG
From: Ramesh Gangadhar
Sent: Tuesday, April 12, 2016 14:41
To: awt-dev@openjdk.java.net
Subject: Re: Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hi,
Gentle reminder for review.
Regards,
Ambarish
From: Ambarish Rapte
Sent: Tuesday, April 12, 2016 10:03 AM
To: Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan;
awt-dev@openjdk.java.net
Subject: Review request for 6384991: TrayIcon ActionListener called
at wrong time
Hi
On 18/04/16 20:55, Sergey Bylokhov wrote:
On 18.04.16 18:36, Alexander Scherbatiy wrote:
On 4/15/2016 10:55 PM, Sergey Bylokhov wrote:
On 15.04.16 21:49, Phil Race wrote:
I think that even if no exception is thrown we ought to document what
happens.
Which of course means that we need to be
On 18.04.16 18:36, Alexander Scherbatiy wrote:
On 4/15/2016 10:55 PM, Sergey Bylokhov wrote:
On 15.04.16 21:49, Phil Race wrote:
I think that even if no exception is thrown we ought to document what
happens.
Which of course means that we need to be sure that it does happen :-)
And the
On 4/18/2016 6:12 PM, Alexander Scherbatiy wrote:
On 4/1/2016 1:29 PM, Semyon Sadetsky wrote:
Please review the updated version :
http://cr.openjdk.java.net/~ssadetsky/8147842/webrev.01/
fix was changed to avoid possible recursion in native IME evens
handling which the SendMessage() call
On 4/15/2016 10:55 PM, Sergey Bylokhov wrote:
On 15.04.16 21:49, Phil Race wrote:
I think that even if no exception is thrown we ought to document what
happens.
Which of course means that we need to be sure that it does happen :-)
And the difference depending on SM may be hard to defend.
And I
On 4/1/2016 1:29 PM, Semyon Sadetsky wrote:
Please review the updated version :
http://cr.openjdk.java.net/~ssadetsky/8147842/webrev.01/
fix was changed to avoid possible recursion in native IME evens
handling which the SendMessage() call might cause.
The SendMessage call has been added
Hi Manajit.
While pressing x button , the test dialog is not closing in windows.
Please check that. Also, the failure message
/throw new RuntimeException("Updating TrayIcon popup menu"//
//+ " items FAILED");//
/
seems to be wrong.
Regards
Prasanta
On 4/18/2016 2:59
YW.
You can track the new request here
https://bugs.openjdk.java.net/browse/JDK-8154431
--Semyon
On 4/18/2016 11:26 AM, Reto Merz wrote:
That sounds good.
Thanks for you efforts.
Best Regards
Reto Merz
On 4/14/2016 22:11, Semyon Sadetsky wrote:
On 4/14/2016 9:25 PM, Reto Merz wrote:
That sounds good.
Thanks for you efforts.
Best Regards
Reto Merz
On 4/14/2016 22:11, Semyon Sadetsky wrote:
> On 4/14/2016 9:25 PM, Reto Merz wrote:
>
> This is a small part of our focus/validation framework.
> I just try to explain it as simple as possible.
>
> javax.swing.InputVerifier
Hi Ajit,
The fix looks good to me.
Please update year 2016 in copyright before pushing.
Regards,
Ambarish
-Original Message-
From: Yuri Nesterenko
Sent: Friday, April 15, 2016 3:57 PM
To: Ajit Ghaisas; Sergey Bylokhov; awt-dev@openjdk.java.net
Subject: Re: JDK-8031423 :
13 matches
Mail list logo
