Re: [9] Review Request: 8155785 Add @Deprecated annotations to the Applet API classes

2016-05-13 Thread Daniil Titov
Thank you all for reviewing these changes. Per Stuart's recommendations I've updated the documentation. Please review the new version of the fix. Webrev : http://cr.openjdk.java.net/~dtitov/8155785/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8155785 Best regards, Daniil -Origi

Re: [9] Review Request: 8155785 Add @Deprecated annotations to the Applet API classes

2016-05-13 Thread Stuart Marks
@deprecated As of JDK 9, the Applet API is deprecated, no replacement. I don't think it's necessary to say "As of JDK 9" since the annotation itself has since="9" in it. The text seems like it's missing something. It's true there is no direct replacement for the Applet API. But somebody l

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

2016-05-13 Thread Manajit Halder
Hi Semyon, The fix is changed a bit because it was observed that the modifier keys plus alphabet keys were not working together. In the modified fix only Num keys are posted by AXUIElementPostKeyboardEvent and remaining keys are posted by CGPostKeyboardEvent/CGEventPost. The fix is explained in

Re: [9] Review Request: 8155785 Add @Deprecated annotations to the Applet API classes

2016-05-13 Thread Phil Race
+1 -phil. On 05/12/2016 06:41 PM, Daniil Titov wrote: Hello, Please review the fix for JDK 9. The fix adds @Deprecated annotations to the Applet API classes as per JEP 289 "Deprecate the Applet API" ( http://openjdk.java.net/jeps/289 ). @SuppressWarnings("deprecation") annotations were ad

Re: Review request for 8145284: [Documentation] [TextField] Missing new line character handling

2016-05-13 Thread Ambarish Rapte
Hi Prasanta, Please review the updated the webrev, made changes by adding a comment to 2 Text Field constructors & setText API. Webrev: http://cr.openjdk.java.net/~arapte/8145284/webrev.01/ I shall raise CCC after technical revie

Re: [9] Review Request: 8155785 Add @Deprecated annotations to the Applet API classes

2016-05-13 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 13/05/16 06:56, Sergey Bylokhov wrote: cc swing-dev. Looks fine. On 13.05.16 4:41, Daniil Titov wrote: Hello, Please review the fix for JDK 9. The fix adds @Deprecated annotations to the Applet API classes as per JEP 289 “Deprecate the