Re: [9] Review request for 8157827: AWT_Desktop/Automated/Exceptions/BasicTest loads incorrect GTK version when jdk.gtk.version=3

2016-05-26 Thread Phil Race
So is there a missing file here or not ? -phil. On 05/26/2016 12:12 AM, Semyon Sadetsky wrote: I am sorry for any misunderstanding I may have caused. That was your request in http://mail.openjdk.java.net/pipermail/swing-dev/2016-April/005773.html : >I think we can/should quickly fix the

[9] Review request for 8156121: "Fail forward" fails for GTK3 if no GTK2 available

2016-05-26 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8156121 webrev: http://cr.openjdk.java.net/~ssadetsky/8156121/webrev.00/ The issue is caused by changes in -Djdk.gtk.version= specification. Initially it should be working as a constraint: only allow the

Re: Public RequestFocusController/AWTAccessor API

2016-05-26 Thread Reto Merz
This is a small part of our focus/validation framework. I just try to explain it as simple as possible. javax.swing.InputVerifier gives only access to the source component. We need to know the target component. Would it be possible to overload verify(..) (or introduce another method) which

Re: Public RequestFocusController/AWTAccessor API

2016-05-26 Thread Reto Merz
Exactly, the target can reject the focus transfer (and the source too). All our UI components support "FocusRequestEnterExit" listeners which has a requestEnter(EnterExitEvent) and requestExit(EnterExitEvent) method (among others focusGained/focusLost methods). The EnterExitEvent has a reject()

Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

2016-05-26 Thread Semyon Sadetsky
On 5/24/2016 2:09 PM, Manajit Halder wrote: Hi Semyon, It is not clear in the comment what was the problem, but it looks like the problem was observed just by using CGEventCreateKeyboardEvent/CGEventPost. In my case I don’t see any issues just by using the fix. It posts all the key events

Re: [9] Review request for 8157827: AWT_Desktop/Automated/Exceptions/BasicTest loads incorrect GTK version when jdk.gtk.version=3

2016-05-26 Thread Semyon Sadetsky
I am sorry for any misunderstanding I may have caused. That was your request in http://mail.openjdk.java.net/pipermail/swing-dev/2016-April/005773.html : >I think we can/should quickly fix the new ordinal() usage and file a >separate bug for the GTKEngine usage. I just fulfilled it. But, my