Do we need the suppression in JavaSoundAudioClip.java as I could not
find any mention of Applet in that class?
In AppletViewer.java
shouldn't we need to add "deprecation" to
45 @SuppressWarnings("serial") // JDK implementation class Do we still need this
160 @SuppressWarnings("deprecation"
I guess we can extract some of the common logic in the fix, upto other
reviewers, this looks fine to me.
On 25.10.16 19:25, Alexander Zvegintsev wrote:
Please see the updated webrev:
http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/
Thanks,
Alexander.
On 10/11/16 5:00 PM, Alexander Zve
OK but I think a code comment in an answer to Sergey's question is
warranted -
explaining how the "new" thread is needed because of displayChanged
making a synchronous call on to the toolkit thread.
Otherwise it looks quite odd on its own.
Also make sure this is tested both with & without D3D.
+1
--Semyon
On 02.11.2016 20:07, Sergey Bylokhov wrote:
Looks fine.
On 02.11.16 7:44, Ambarish Rapte wrote:
Hi,
Please review this doc change,
Webrev:
http://cr.openjdk.java.net/~arapte/6614519/webrev.00/
Bug: https://bugs.openjdk.java.net/b
On 20.10.16 1:14, Philip Race wrote:
Well maybe but this isn't about adding deprecations it is just
about of getting rid of warnings for uses of APIs that are
already deprecated.
ok.
You are welcome to file a separate bug on that ...
-phil.
On 10/19/16, 2:59 PM, Sergey Bylokhov wrote:
On
Looks fine.
On 02.11.16 7:44, Ambarish Rapte wrote:
Hi,
Please review this doc change,
Webrev:
http://cr.openjdk.java.net/~arapte/6614519/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-6614519
Change:
/DragSourceContext/uses either
+1
Thanks,
Alexander.
On 11/1/16 10:59 PM, Sergey Bylokhov wrote:
Looks fine.
On 05.10.16 11:45, Semyon Sadetsky wrote:
To avoid this the 8139218 solution is revisited to manage the focus
restore synchronously only if it is possible and send a single
asynchronous focus request otherwise.
Ca
Hi Alexander,
Please review updated patch.
http://cr.openjdk.java.net/~pkbalakr/8162959/webrev.01/
Added a new public API "Image createHiDPIScreenCapture(Rectangle screenRect)".
Returns an ordinary screenshot(BufferedImage) if the UI scale is 1.
Returns MultiResolutionImage for HiDPI
Can I get another +1 for this fix?
Regards,
Ajit
-Original Message-
From: Erik Joelsson
Sent: Thursday, October 27, 2016 3:30 PM
To: Ajit Ghaisas; build-...@openjdk.java.net; awt-dev@openjdk.java.net
Subject: Re: Fix for JDK-8160146 : Resolve disabled GCC warning
'deprecated-declaration
