yes, this is a potential issue. But actually cases MID,FOCUS,BLACK,WHITE
are never used.
But the fix is wrong. It should be
color.alpha = 1; --Semyon
On 01.12.2016 08:05, Prasanta Sadhukhan wrote:
Also, in gtk3_interface.c, there is this change for color.alpha
2219 color.alpha = 0; in gtk3
Hi Vincent,
I fixed the typo and added a remark to the first line of the bug text.
Best regards,
Goetz.
> -Original Message-
> From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
> Sent: Mittwoch, 30. November 2016 17:10
> To: Lindenmaier, Goetz
> Cc: awt-dev@openjdk.java.net; secu
On 01.12.2016 03:18, Sergey Bylokhov wrote:
On 29.11.16 20:55, Semyon Sadetsky wrote:
I doubt how it is possible. If the Paint event was posted from the
resize event it will reset the paintPainding to "false" in the
WComponentPeer.handleEvent():
switch(id) {
case PaintEvent.
Also, in gtk3_interface.c, there is this change for color.alpha
2219 color.alpha = 0; in gtk3_get_color_for_flags()
but it is used in
gtk3_get_color_for_state() where it is not initialized
2268 GdkRGBA color;
Regards
Prasanta
On 12/1/2016 1:28 AM, Phil Race wrote:
Hi Goetz,
DataBuffer
Hi, Dmitry.
Is it true that the window is disable only if blocked by some other
window? Is it possible a situation when it can be disabled by
application and in the same moment can have an enabled child which
should be moved upfront?
--
Best regards, Sergey.
On 29.11.16 20:55, Semyon Sadetsky wrote:
I doubt how it is possible. If the Paint event was posted from the
resize event it will reset the paintPainding to "false" in the
WComponentPeer.handleEvent():
switch(id) {
case PaintEvent.PAINT:
// Got native painting
Note that I have reviewed only the ECC/PKCS11 changes.
You’ll need a JDK 9 reviewer from awt-dev for your remaining changes.
There is a minor typo in the commit message: s/ece/ECC
Also please change the Bug Summary in JBS to indicate that ECC and PKCS11
changes are also present.
> On 30 Nov 20
Hello Goetz,
Please modify the bug summary to reference ECC too.
Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source
code headers will need to be updated/added.
BTW p11_mutex.c is listed below but appears to be missing from the webrev.
Thanks.
> On 30 Nov 2016, at 13
Hi Goetz,
I have some small remarks.
src/java.desktop/unix/native/common/awt/fontpath.c:
247 fontDirPath[sizeof(fontDirPath)-1] = '\0';
-> you should add spaces left and right of '-'
248 strncat(fontDirPath, "/fonts.dir", sizeof(fontDirPath) -
strlen(fontDirPath));
-> I
Hi Goetz,
DataBufferNative.c
Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer.
75 lockInfo.resBase = NULL;
Did you actually compile this ? The variable is called "rasBase", not
"resBase".
And strictly there is no problem since inside DBN_GetPixelPointer
cc 2d-dev.
On 30.11.16 18:41, Lindenmaier, Goetz wrote:
Hi Vincent,
thanks for the quit review!
Good catch that I lost the change to p11_mutex.c ... I had to change
it and it fell out of my patches.
I edited the Last Modified Date, and also updated the copyright messages.
New webrev:
http://cr.
Hi Vincent,
thanks for the quit review!
Good catch that I lost the change to p11_mutex.c ... I had to change
it and it fell out of my patches.
I edited the Last Modified Date, and also updated the copyright messages.
New webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/
Best rega
Hi,
I'd like to propose a row of smaller fixes where code is noted down a bit
questionable.
SAP's quality process requires that we fix these in our internal delivery, and I
Would like to share my fixes with openJdk. Some of these fixes are of more
theoretical nature as how I understand the code
Hello,
Could you review a fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8165428
webrev: http://cr.openjdk.java.net/~dmarkov/8165428/webrev.00/
Problem description:
Sometimes the function orderChildWindows() might be called for the window which
is blocked by
14 matches
Mail list logo
