Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2017-03-29 Thread Philip Race
This would be a reasonable thing to try to fix before 9 GA I think. Can't affect many tests since the code is new .. -phil. On 3/29/17, 1:22 PM, Sergey Bylokhov wrote: Hi, Jim, Phil. I have started to use MRI and a new Robot in some of the tests and wonder why the MultiResolutionImage does no

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2017-03-29 Thread Sergey Bylokhov
Hi, Jim, Phil. I have started to use MRI and a new Robot in some of the tests and wonder why the MultiResolutionImage does not use generics for getResolutionVariants()? So for example if we have an API like: http://download.java.net/java/jdk9/docs/api/java/awt/Robot.html#createMultiResolutionScre

Re: [9] Review request for 8177625 apple.laf.JRSUIConstants.getConstantName(int) checks for THUMB_START twice

2017-03-29 Thread Philip Race
+1 -phil. On 3/29/17, 6:49 AM, Alexander Zvegintsev wrote: +1 -- Thanks, Alexander. On 29.03.2017 15:10, Sergey Bylokhov wrote: Looks fine. Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8177625 webrev: http://cr.openjdk.java.net/~alexsch/8177625/webrev

Re: [9] Review request for 8177625 apple.laf.JRSUIConstants.getConstantName(int) checks for THUMB_START twice

2017-03-29 Thread Alexander Zvegintsev
+1 -- Thanks, Alexander. On 29.03.2017 15:10, Sergey Bylokhov wrote: Looks fine. Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8177625 webrev: http://cr.openjdk.java.net/~alexsch/8177625/webrev.00 The typo with twice used THUMB_START constant is fixed.

Re: [9] Review request for 8177625 apple.laf.JRSUIConstants.getConstantName(int) checks for THUMB_START twice

2017-03-29 Thread Sergey Bylokhov
Looks fine. > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8177625 > webrev: http://cr.openjdk.java.net/~alexsch/8177625/webrev.00 > > The typo with twice used THUMB_START constant is fixed. > > Thanks, > Alexandr. >

Re: [OpenJDK 2D-Dev] [9] Review Request: 8177461 Wrong references are used in the javadoc in the java.desktop module

2017-03-29 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 23/03/17 18:24, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. In java.desktop module in a various places we use incorrect links. Most of them are in the documentation in non-public classes/methods(But there are two places in publi

[9] Review request for 8177625 apple.laf.JRSUIConstants.getConstantName(int) checks for THUMB_START twice

2017-03-29 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8177625 webrev: http://cr.openjdk.java.net/~alexsch/8177625/webrev.00 The typo with twice used THUMB_START constant is fixed. Thanks, Alexandr.