[10] Review request for 8178448: MenuBar item handler fired twice

2017-08-01 Thread Alexander Zvegintsev
Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178448 This Mac specific issue happens if setDefaultMenuBar() is called after setJMenuBar() with same instance of JMenuBar. JFrame.setJMenuBar(mb);

Re: [OpenJDK 2D-Dev] [10] JDK-8169044: The tray icon color is not green

2017-08-01 Thread Sergey Bylokhov
Hi, Shashi. As far as I understand the "width/height" in the IconCanvas is a size of the TrayIcon in pixels. So on the normal screen it is should be 24(TRAY_ICON_WIDTH) pixels and on a HiDPI screen it should be 24*ScreenScale. The IconCanvas.width/height fields should reflect this size. I am

Re: [10][JDK-8027154] [TESTBUG] Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

2017-08-01 Thread Sergey Bylokhov
Ok, looks fine. Thank you for clarification. - krishna.addepa...@oracle.com wrote: > > > Hi Sergey, Based on our conversation, could you provide your review comments for the fix? Pasting the mail exchange below for reference: The intent of the test is not modified by my

Re: [OpenJDK 2D-Dev] [10] JDK-8169044: The tray icon color is not green

2017-08-01 Thread Shashidhara Veerabhadraiah
Yes Jim. Per the current code base, it is defaulted to default screen. To have the same tray icon being represented on multiple task bars would require updates to XSystemTrayPeer.java to replicate the message being sent to X11 to add a new tray icon for a particular screen(Currently it is done

Re: [10][JDK-8027154] [TESTBUG] Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

2017-08-01 Thread Krishna Addepalli
Hi Sergey,   Based on our conversation, could you provide your review comments for the fix?   Pasting the mail exchange below for reference:     The intent of the test is not modified by my changes. By having the second frame register a mouse move callback, it is made more explicit - when