Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

Hi, Alexander. How can we be sure that the parent frame will not be disposed while we use a pointer? long ownerWindowPtr = peer.getOverridenWindowHandle(); < Dispose the peer if (ownerWindowPtr != 0) { //Place window above JavaFX stage CWrapper.NSWindow.addChildWindow(

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

Hi, Prasanta. On 9/19/17 22:26, Prasanta Sadhukhan wrote: Hi, Prasanta.  - In this version it is unclear what is a purpose of the "fxCheckSequenceThread.start()". This code will start the thread and will continue execution, it will not wait when the thread will stop.  - The

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

I need to look more closely but at a quick glance I don't see any problems so a tentative +1 .. but a final +1 will go in the bug. Have you tested the various configurations .. running this on top of current JDK (not FX) 10 both with and without the FX changes ? -phil. On 09/21/2017 10:56

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Alexey, On 09/22/2017 01:01 PM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 20:06, Semyon Sadetsky wrote: Hi Alexey, On 09/22/2017 10:53 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 18:29, Semyon Sadetsky wrote: Hi Alexey, On 09/22/2017 09:43 AM, Alexey Ivanov wrote: Hi

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Semyon, On 22/09/2017 20:06, Semyon Sadetsky wrote: Hi Alexey, On 09/22/2017 10:53 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 18:29, Semyon Sadetsky wrote: Hi Alexey, On 09/22/2017 09:43 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 17:13, Semyon Sadetsky wrote: Hi

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Alexey, On 09/22/2017 10:53 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 18:29, Semyon Sadetsky wrote: Hi Alexey, On 09/22/2017 09:43 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 17:13, Semyon Sadetsky wrote: Hi Alexey, Thank you for your exact clarification. On 09/22/2017

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Semyon, On 22/09/2017 18:29, Semyon Sadetsky wrote: Hi Alexey, On 09/22/2017 09:43 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 17:13, Semyon Sadetsky wrote: Hi Alexey, Thank you for your exact clarification. On 09/22/2017 04:22 AM, Alexey Ivanov wrote: As for FILE_ICON_SMALL

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Alexey, On 09/22/2017 09:43 AM, Alexey Ivanov wrote: Hi Semyon, On 22/09/2017 17:13, Semyon Sadetsky wrote: Hi Alexey, Thank you for your exact clarification. On 09/22/2017 04:22 AM, Alexey Ivanov wrote: As for FILE_ICON_SMALL and FILE_ICON_LARGE, I'd suggest using Windows API to

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Semyon, On 22/09/2017 17:13, Semyon Sadetsky wrote: Hi Alexey, Thank you for your exact clarification. On 09/22/2017 04:22 AM, Alexey Ivanov wrote: As for FILE_ICON_SMALL and FILE_ICON_LARGE, I'd suggest using Windows API to retrieve the recommended size for small and large icon size

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Alexey, Thank you for your exact clarification. On 09/22/2017 04:22 AM, Alexey Ivanov wrote: Hi Sergey, On 22/09/2017 04:21, Sergey Bylokhov wrote: On 9/21/17 14:12, Semyon Sadetsky wrote: On 09/21/2017 01:52 PM, Sergey Bylokhov wrote: On 9/21/17 08:54, Semyon Sadetsky wrote: On

Re: [10] Review Request: 8186559 [macos] the screen location is wrong when using AWT/SWT bridge with dual monitors

Hi Sergey, The fix still looks good for me. Thanks, Dmitry > On 18 Sep 2017, at 23:04, Sergey Bylokhov wrote: > > On 9/18/17 09:53, Semyon Sadetsky wrote: >> On 09/15/2017 02:29 PM, Sergey Bylokhov wrote: >>> It is broken from the moment when it was implemented(I

Re: [10] JDK-8178361: JFileChooser does not allow to open folders with a double tap when using the touch screen interface

Hi Shashi, On 19/09/2017 04:35, Shashidhara Veerabhadraiah wrote: Hi Sergey, When I checked it was not working on the Java applications. None of the controls could take touch click events but it used to highlight because when we touch on the touch screen interface the system moves the cursor

Re: [10] JDK-8178361: JFileChooser does not allow to open folders with a double tap when using the touch screen interface

Hi Shashi, You use EnableMouseInPointer which converts classical WM_MOUSE events to WM_POINTER events. This could have substantial effect on AWT components behaviour. I am worried about High DPI support, drag-and-drop functionality etc. Is there a simpler way to handle double-tap? Windows

Re: [10] Review request for 8182043: Access to Windows Large Icons

Hi Sergey, On 22/09/2017 04:21, Sergey Bylokhov wrote: On 9/21/17 14:12, Semyon Sadetsky wrote: On 09/21/2017 01:52 PM, Sergey Bylokhov wrote: On 9/21/17 08:54, Semyon Sadetsky wrote: On 09/20/2017 02:41 PM, Sergey Bylokhov wrote: Hi, Semyon I have some initial comments which are based on