Re: [10] Review request for 8182638: [macosx] Active modal dialog is hidden by another non-active one

2017-10-08 Thread Alexander Zvegintsev
Looks good to me, BTW in the test DialogListener can be replaced with WindowAdapter Thanks, Alexander. On 07/10/2017 01:17, Semyon Sadetsky wrote: Hello, Please review fix for JDK10: bug: https://bugs.openjdk.java.net/browse/JDK-8182638 webrev: http://cr.openjdk.java.net/~ssadetsky/8182638/

Re: [10] Review Request: 8187639 TrayIcon is not properly supported on macOS in multi-screen environment

2017-10-08 Thread Alexander Zvegintsev
Looks fine Thanks, Alexander. On 27/09/2017 22:37, Sergey Bylokhov wrote: Hello, Please review the fix for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8187639 Webrev can be found at: http://cr.openjdk.java.net/~serb/8187639/webrev.01 Since macOS 10.9(or even early) the main menuba

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-10-08 Thread Alexander Zvegintsev
Please review the updated version http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/ Now we are postponing actual window closing, it happens only after we ensure that native window pointer is valid on Swing side. Thanks, Alexander. On 23/09/2017 08:01, Sergey Bylokhov wrote: Hi, Alexand

Re: Why was JDK-8188085 closed? (non-English Java apps broken on High Sierra, menubar missing)

2017-10-08 Thread Hendrik Schreiber
> On Oct 8, 2017, at 16:41, Alan Snyder wrote: > > What I notice is that on 10.12, the directory > /System/Library/Frameworks/JavaVM.framework/Versions/A/Resources contains > many DefaultApp.nib files, but on 10.13, there is only one. Interesting observation. Can you confirm the theory someh

Re: Why was JDK-8188085 closed? (non-English Java apps broken on High Sierra, menubar missing)

2017-10-08 Thread Alan Snyder
What I notice is that on 10.12, the directory /System/Library/Frameworks/JavaVM.framework/Versions/A/Resources contains many DefaultApp.nib files, but on 10.13, there is only one. On 10.12: ./ar.lproj/DefaultApp.nib ./ca.lproj/DefaultApp.nib ./cs.lproj/DefaultApp.nib ./da.lproj/DefaultApp.nib .

Re: Why was JDK-8188085 closed? (non-English Java apps broken on High Sierra, menubar missing)

2017-10-08 Thread Hendrik Schreiber
> On Oct 7, 2017, at 21:49, Victor D'yakov > wrote: > > Sergey, please spend your cycle to re-evaluate this issue, it may be an > Apple's problem but in that case it would be "not an issue", in that case we > need you to report it with Apple's bugID here. > > H