Re: [10] Review Request: 8187639 TrayIcon is not properly supported on macOS in multi-screen environment

2017-10-12 Thread Sergey Bylokhov
This is one of the task of awt to provide a native appearance, the FileDialog is one of the examples. The current fix provide the same functionality like the old code, it looks is native, it works in a multi-screen environment. I think that we should implement the same fix for linux/windows as

Re: [10] Review request for 8182043: Access to Windows Large Icons

2017-10-12 Thread Sergey Bylokhov
On 06/10/2017 17:16, Semyon Sadetsky wrote: The maximum icon which we used before you fix is 32pixel's icon(yes it is a large icon), and 128 is a size of this icon on 4k monitor( The windows can return a 128pixel's icon on 4k monitor) The EXTRA_LARGE and JAMBO was not used in our code. So, it

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-10-12 Thread Sergey Bylokhov
Looks fine. I am not sure but it looks like the fix has an assumption that the CPlatformWindow.setVisible() code will be executed on EDT/Appkit but it is not the case. This code can be executed on any thread(intentionally for crash), and it will be good to check that it works as expected by