On Mon, 8 Feb 2021 14:22:27 GMT, Kevin Rushforth wrote:
>> I think, a generic name is OK as the path of shader file already has both
>> awt (libawt_lwawt) and java2d in it.
>
> In the source tree, yes, but not in the jdk image where it ends up in
> `$JAVA_HOME/lib/shaders.metallib`. I don't
On Mon, 8 Feb 2021 22:41:01 GMT, Sergey Bylokhov wrote:
> The test is moved to the "java/awt/Graphics/" since it validates behavior of
> the java.awt.Graphics$setColor() method.
This pull request has now been integrated.
Changeset: 5d8204b1
Author:Sergey Bylokhov
URL:
On Mon, 8 Feb 2021 22:41:01 GMT, Sergey Bylokhov wrote:
> The test is moved to the "java/awt/Graphics/" since it validates behavior of
> the java.awt.Graphics$setColor() method.
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2467
On Mon, 8 Feb 2021 12:28:07 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
The test is moved to the "java/awt/Graphics/" since it validates behavior of
the java.awt.Graphics$setColor() method.
-
Commit messages:
- Update TestNullSetColor.java
Changes: https://git.openjdk.java.net/jdk/pull/2467/files
Webrev:
On Mon, 8 Feb 2021 12:28:07 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
On Mon, 8 Feb 2021 17:15:25 GMT, Gerard Ziemski wrote:
> General comment - I am not sure I like the `MTL` prefix acronym in names (ex.
> `sun.java2d.metal.MTLVolatileSurfaceManager`).
>
> I think you tried to match the `CGL`, but that is a real acronym that stands
> for "Core Graphics Layer"
On Mon, 8 Feb 2021 17:15:25 GMT, Gerard Ziemski wrote:
>> The file in `RenderPerfTest` should have a GPLv2 license header (no
>> Classpath). I filed
>> [JDK-8261273](https://bugs.openjdk.java.net/browse/JDK-8261273) and also
>> highlighted a couple examples below.
>
> General comment - I am
On Sat, 6 Feb 2021 00:53:08 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> The file in `RenderPerfTest` should have a GPLv2 license header (no
>
On Sun, 7 Feb 2021 08:29:57 GMT, Dmitry Markov wrote:
> The function InvokeInputMethodFunction() is responsible for invocation of IME
> API. Typically it uses PostMessage() to execute corresponding IME function on
> the toolkit thread but if DnD operation takes place SendMessage() is used.
>
On Mon, 8 Feb 2021 16:51:21 GMT, Alexander Zuev wrote:
> Change looks good and i haven't found any side-effects during testing. Could
> you please add the label to the bug noting reason for absence of the
> regression test, like noreg-hard or something?
Thank you for the review. I have added
On Sun, 7 Feb 2021 08:29:57 GMT, Dmitry Markov wrote:
> The function InvokeInputMethodFunction() is responsible for invocation of IME
> API. Typically it uses PostMessage() to execute corresponding IME function on
> the toolkit thread but if DnD operation takes place SendMessage() is used.
>
On Mon, 8 Feb 2021 16:51:21 GMT, Alexander Zuev wrote:
>> The function InvokeInputMethodFunction() is responsible for invocation of
>> IME API. Typically it uses PostMessage() to execute corresponding IME
>> function on the toolkit thread but if DnD operation takes place
>> SendMessage() is
On Sun, 7 Feb 2021 08:29:57 GMT, Dmitry Markov wrote:
> The function InvokeInputMethodFunction() is responsible for invocation of IME
> API. Typically it uses PostMessage() to execute corresponding IME function on
> the toolkit thread but if DnD operation takes place SendMessage() is used.
>
On Mon, 8 Feb 2021 13:40:22 GMT, Ajit Ghaisas wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 894:
>>
>>> 892: SHADERS_SUPPORT_DIR :=
>>> $(SUPPORT_OUTPUTDIR)/native/java.desktop/libosxui
>>> 893: SHADERS_AIR := $(SHADERS_SUPPORT_DIR)/shaders.air
>>> 894: SHADERS_LIB :=
On Fri, 5 Feb 2021 18:42:02 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lanai PR#175 - 8261304 - aghaisas
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 894:
>
>> 892:
> **Description :**
> This is the implementation of [JEP 382 : New macOS Rendering
> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
> It implements a Java 2D internal rendering pipeline for macOS using the Apple
> Metal API.
> The entire work on this was done under [OpenJDK Project
17 matches
Mail list logo
