Re: RFR: 8255800: Raster creation methods need some specification clean up [v2]

2021-04-01 Thread Phil Race
On Thu, 1 Apr 2021 00:56:41 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8255800: Raster creation methods need some specification clean up > > Marked as reviewed by serb (Reviewer). I've

Re: RFR: 8255800: Raster creation methods need some specification clean up [v2]

2021-04-01 Thread Phil Race
> https://bugs.openjdk.java.net/browse/JDK-8255800 could have been a one line > spec clean up but > it didn't take a lot of looking to realize there were many more > inconsistencies between spec and implementation. > I've spent a lot of time on what is just small number of factory methods in >

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-01 Thread Sergey Bylokhov
On Thu, 1 Apr 2021 14:38:52 GMT, Alexey Ushakov wrote: > Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. > MTLLayer.h header cleanup. Is it possible to automatically test it? src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1171: > 1169:

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop

2021-04-01 Thread Aleksey Shipilev
On Thu, 1 Apr 2021 12:48:52 GMT, Andrey Turbanov wrote: >> Looks like this change goes beyond of simple replacement of StringBuffer >> with StringBuilder. Please update the description of the bug and PR >> description. > > I've updated PR description, but I don't have rights to update JIRA.

RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-01 Thread Alexey Ushakov
Dynamically change MTLLayer insets depending on FULL_WINDOW_CONTENT property. MTLLayer.h header cleanup. - Commit messages: - 8258788: incorrect response to change in window insets [lanai] Changes: https://git.openjdk.java.net/jdk/pull/3308/files Webrev:

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol

2021-04-01 Thread Pankaj Bansal
On Wed, 31 Mar 2021 19:56:24 GMT, Sergey Bylokhov wrote: > Ok, please file a similar bug for the windows platform. I have created the bug for windows here https://bugs.openjdk.java.net/browse/JDK-8264598. I have also created the CSR for the current issue. - PR:

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop

2021-04-01 Thread Andrey Turbanov
On Wed, 31 Mar 2021 21:12:37 GMT, Sergey Bylokhov wrote: >> Submitted: https://bugs.openjdk.java.net/browse/JDK-8264428, please rename >> PR to "8264428: Replace uses of StringBuffer with StringBuilder in >> java.desktop". > > Looks like this change goes beyond of simple replacement of

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v3]

2021-04-01 Thread Pankaj Bansal
> Create implementation of NSAccessibilitySlider protocol > https://developer.apple.com/documentation/appkit/nsaccessibilityslider > > The implementation has the function performIncrement and performDecrement to > increase/decrease the value of slider using the VoiceOver. To implement this >

Integrated: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

2021-04-01 Thread Alexander Scherbatiy
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy wrote: > Printing text using GlyphVector outline has bad quality on printers with low > DPI on Windows. > The GDI system used for text printing on Windows accepts only integer path > coordinates. > Rounding GlyphVector outline coordinates