RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-08 Thread Tejpal Rebari
Hi All, Please review the following fix for jdk17. Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full Screen when the System Preference -> General -> Prefer Tabs is set to "Full Screen". It is also freezing in normal screen when Prefer Tabs is set to "Always". It

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-04-08 Thread Alexander Zuev
On Fri, 9 Apr 2021 04:55:18 GMT, Prasanta Sadhukhan wrote: > This testcase was a regression testcase for a windows bug JDK-6242241 whereby > dragging an attachment from a Microsoft Outlook message to the application > results in blank or semicolons. > The testcase was later made applicable to

RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-04-08 Thread Prasanta Sadhukhan
This testcase was a regression testcase for a windows bug JDK-6242241 whereby dragging an attachment from a Microsoft Outlook message to the application results in blank or semicolons. The testcase was later made applicable to windows only by JDK-7147083

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-08 Thread Sergey Bylokhov
On Wed, 7 Apr 2021 23:04:04 GMT, Alexey Ushakov wrote: > Perform replaceSurfaceData on insets change src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java line 741: > 739: if (CGraphicsDevice.usingMetalPipeline() && invalid) { > 740: replaceSurfaceData(); >

Integrated: 8264428: Cleanup usages of StringBuffer in java.desktop

2021-04-08 Thread Andrey Turbanov
On Mon, 29 Mar 2021 20:50:14 GMT, Andrey Turbanov wrote: > There are few possible cleanups in java.desktop related to legacy > StringBuffer usages: > 1. In few places StringBuffer can be replaced with plain String concatenation. > 2. StringBuffer can be replaced with StringBuilder.

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v4]

2021-04-08 Thread Alexander Zvegintsev
On Thu, 8 Apr 2021 14:43:50 GMT, Andrey Turbanov wrote: >> There are few possible cleanups in java.desktop related to legacy >> StringBuffer usages: >> 1. In few places StringBuffer can be replaced with plain String >> concatenation. >> 2. StringBuffer can be replaced with StringBuilder.

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-08 Thread Alexey Ushakov
On Wed, 7 Apr 2021 20:29:12 GMT, Alexey Ushakov wrote: >>> @avu Test passes without fix also. >> @jayathirthrao Could you provide the details about your configuration along >> with parameters passed to jtreg ? > >> @avu I am running test in 13 inch Macbook Early 2015 with integrated Intel >>

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v4]

2021-04-08 Thread Alexey Ivanov
On Thu, 8 Apr 2021 14:43:50 GMT, Andrey Turbanov wrote: >> There are few possible cleanups in java.desktop related to legacy >> StringBuffer usages: >> 1. In few places StringBuffer can be replaced with plain String >> concatenation. >> 2. StringBuffer can be replaced with StringBuilder.

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v4]

2021-04-08 Thread Andrey Turbanov
> There are few possible cleanups in java.desktop related to legacy > StringBuffer usages: > 1. In few places StringBuffer can be replaced with plain String concatenation. > 2. StringBuffer can be replaced with StringBuilder. StringBuilder has better > performance as it is not thread-safe. > 3.

Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v3]

2021-04-08 Thread Andrey Turbanov
On Wed, 7 Apr 2021 15:21:40 GMT, Alexey Ivanov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> [PATCH] Replace uses of StringBuffer with StringBuilder in java.desktop >> >> fix copyright year > >

Re: RFR: 8263363: Minor cleanup of Lanai code - unused code removal and comments correction [v3]

2021-04-08 Thread Ajit Ghaisas
> Refer JBS for 3 issues that this PR addresses. > In addition, I have corrected an erroneous free() call in the same method I > was cleaning up. Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: log message correction -

Re: RFR: 8263363: Minor cleanup of Lanai code - unused code removal and comments correction [v2]

2021-04-08 Thread Ajit Ghaisas
> Refer JBS for 3 issues that this PR addresses. > In addition, I have corrected an erroneous free() call in the same method I > was cleaning up. Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: Review fixes - Changes:

Re: RFR: 8262981: Create implementation for NSAccessibilitySlider protocol [v3]

2021-04-08 Thread Alexander Zuev
On Thu, 1 Apr 2021 12:12:40 GMT, Pankaj Bansal wrote: >> Create implementation of NSAccessibilitySlider protocol >> https://developer.apple.com/documentation/appkit/nsaccessibilityslider >> >> The implementation has the function performIncrement and performDecrement to >> increase/decrease