Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Jayathirth D V
On Sat, 10 Apr 2021 05:52:16 GMT, Jayathirth D V wrote: >> Alexey Ushakov has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Jayathirth D V
On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-09 Thread Prasanta Sadhukhan
On Sat, 10 Apr 2021 03:36:53 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove Outlook requirement > > test/jdk/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java line

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-09 Thread Sergey Bylokhov
On Sat, 10 Apr 2021 02:59:00 GMT, Prasanta Sadhukhan wrote: >> This testcase was a regression testcase for a windows bug JDK-6242241 >> whereby dragging an attachment from a Microsoft Outlook message to the >> application results in blank or semicolons. >> The testcase was later made

Re: RFR: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 21:50:39 GMT, Alexey Ushakov wrote: > Implemented apple.awt.windowTitleVisible property to control window title > visibility - PR: https://git.openjdk.java.net/jdk/pull/3425

Re: RFR: 8258788: incorrect response to change in window insets [lanai]

2021-04-09 Thread Jayathirth D V
On Wed, 7 Apr 2021 23:04:04 GMT, Alexey Ushakov wrote: > Perform replaceSurfaceData on insets change @avu I am running CI tests, please wait until EOD for integration. - PR: https://git.openjdk.java.net/jdk/pull/3390

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v3]

2021-04-09 Thread Prasanta Sadhukhan
> This testcase was a regression testcase for a windows bug JDK-6242241 whereby > dragging an attachment from a Microsoft Outlook message to the application > results in blank or semicolons. > The testcase was later made applicable to windows only by JDK-7147083 >

Re: RFR: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible

2021-04-09 Thread Alan Snyder
Is this property (and others like it) documented somewhere application developers will look? > On Apr 9, 2021, at 2:57 PM, Alexey Ushakov wrote: > > Implemented apple.awt.windowTitleVisible property to control window title > visibility > > - > > Commit messages: > - 8265005:

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 21:26:18 GMT, Alexey Ushakov wrote: >> macOS 11.2(20D64), did you set the sRGB color profile in the settings? > > Yes, it's IEC61966-2.1 Ok, found the issue on my side, by default the test uses the OGL, not a metal. - PR:

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 20:42:26 GMT, Kevin Rushforth wrote: > if you open a modal window that isn't a child window of some other window, it > can lead to strange behavior when you try to tab between them. Yes, this is what I tried to clarify, why we have such "strange behavior", what is the root

RFR: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible

2021-04-09 Thread Alexey Ushakov
Implemented apple.awt.windowTitleVisible property to control window title visibility - Commit messages: - 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible Changes: https://git.openjdk.java.net/jdk/pull/3425/files Webrev:

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
On Fri, 9 Apr 2021 19:59:38 GMT, Sergey Bylokhov wrote: >> What OS version do you have? > > macOS 11.2(20D64), did you set the sRGB color profile in the settings? Yes, it's IEC61966-2.1 - PR: https://git.openjdk.java.net/jdk/pull/3390

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Kevin Rushforth
On Fri, 9 Apr 2021 20:42:26 GMT, Kevin Rushforth wrote: >>> > Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS >>> > release staring from 10.12. >>> > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default >>> > value changed in macos11. >>> >>> But why the

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Kevin Rushforth
On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari wrote: > Hi All, > Please review the following fix for jdk17. > > Issue : On MacOS 11 Java Frame and JDialog application is freezing in Full > Screen when the System Preference -> General -> Prefer Tabs is set to "Full > Screen". It is also

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Kevin Rushforth
On Fri, 9 Apr 2021 07:21:55 GMT, Tejpal Rebari wrote: >>> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release >>> staring from 10.12. >>> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default >>> value changed in macos11. >> >> But why the option

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 19:48:15 GMT, Alexey Ushakov wrote: >> It's strange. Just rerun it with the following command line: >> >> jtreg -Dsun.java2d.metal=True >> -testjdk:/Users/user/ws/jbr-dev/build/macosx-x86_64-server-release/images/jdk-bundle/jdk-17.jdk/Contents/Home >> >>

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
On Fri, 9 Apr 2021 19:38:15 GMT, Alexey Ushakov wrote: >> test/jdk/java/awt/Window/FullWindowContentTest/FullWindowContentRenderTest.java >> line 29: >> >>> 27: * @key headful >>> 28: * @bug 8258788 >>> 29: * @summary [macosx] full window content option rendering test >> >> The test passed

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 07:21:55 GMT, Tejpal Rebari wrote: > As per my understanding we don't have support for opening window in a new Tab. But why we unsupport them? Is it depend on the dialog type? For example, if the option is set to "always prefer tabs" then the test case instruction and the

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
On Fri, 9 Apr 2021 17:33:46 GMT, Sergey Bylokhov wrote: >> Alexey Ushakov has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v2]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 08:25:44 GMT, Prasanta Sadhukhan wrote: >> This testcase was a regression testcase for a windows bug JDK-6242241 >> whereby dragging an attachment from a Microsoft Outlook message to the >> application results in blank or semicolons. >> The testcase was later made

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 11:55:46 GMT, Alexey Ushakov wrote: >> Perform replaceSurfaceData on insets change > > Alexey Ushakov has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v3]

2021-04-09 Thread Alexey Ushakov
> Perform replaceSurfaceData on insets change Alexey Ushakov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v2]

2021-04-09 Thread Alexey Ushakov
On Thu, 8 Apr 2021 21:31:29 GMT, Sergey Bylokhov wrote: >> Alexey Ushakov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258788: incorrect response to change in window insets [lanai] >> >> Moved replaceSurfaceData to more

Re: RFR: 8258788: incorrect response to change in window insets [lanai] [v2]

2021-04-09 Thread Alexey Ushakov
> Perform replaceSurfaceData on insets change Alexey Ushakov has updated the pull request incrementally with one additional commit since the last revision: 8258788: incorrect response to change in window insets [lanai] Moved replaceSurfaceData to more appropriate place -

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v2]

2021-04-09 Thread Prasanta Sadhukhan
> This testcase was a regression testcase for a windows bug JDK-6242241 whereby > dragging an attachment from a Microsoft Outlook message to the application > results in blank or semicolons. > The testcase was later made applicable to windows only by JDK-7147083 >

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor [v2]

2021-04-09 Thread Prasanta Sadhukhan
On Fri, 9 Apr 2021 08:09:16 GMT, Prasanta Sadhukhan wrote: >> The bug was added to the problem list by the JDK-8255365, because SQE >> reported it on Ubuntu in jdk15. This looks strange since the tag "@requires" >> was added in jdk9. >> >> BTW the bug filed JDK-8080185 is unrelated to the

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-04-09 Thread Prasanta Sadhukhan
On Fri, 9 Apr 2021 07:10:14 GMT, Sergey Bylokhov wrote: >> This testcase was a regression testcase for a windows bug JDK-6242241 >> whereby dragging an attachment from a Microsoft Outlook message to the >> application results in blank or semicolons. >> The testcase was later made applicable to

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Tejpal Rebari
On Fri, 9 Apr 2021 07:01:26 GMT, Sergey Bylokhov wrote: > > Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release > > staring from 10.12. > > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > > value changed in macos11. > > But why the option

Re: RFR: 8263363: Minor cleanup of Lanai code - unused code removal and comments correction [v3]

2021-04-09 Thread Sergey Bylokhov
On Thu, 8 Apr 2021 10:39:38 GMT, Ajit Ghaisas wrote: >> src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java line >> 149: >> >>> 147: try { >>> 148: // getMTLConfigInfo() creates new MTLContext, so we should >>> first >>> 149: // invalidate

Re: RFR: 8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 04:55:18 GMT, Prasanta Sadhukhan wrote: > This testcase was a regression testcase for a windows bug JDK-6242241 whereby > dragging an attachment from a Microsoft Outlook message to the application > results in blank or semicolons. > The testcase was later made applicable to

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-04-09 Thread Sergey Bylokhov
On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari wrote: > Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release > staring from 10.12. > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default > value changed in macos11. But why the option