On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan
wrote:
>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
>> all OS. Added synchronization for focusCnt.
>
>
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan
wrote:
> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
> all OS. Added synchronization for focusCnt.
Looks good to me.
-
Marked as reviewed by aivanov (Reviewer).
PR:
Keep MTLLayer opacity in sync with window content view
Keep layer translucent for translucent windows
-
Commit messages:
- 8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL
Changes: https://git.openjdk.java.net/jdk/pull/4946/files
Webrev:
On Fri, 30 Jul 2021 08:40:34 GMT, Pankaj Bansal wrote:
>> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1793:
>>
>>> 1791:
>>> 1792: private void checkIndex(int index) {
>>> 1793: Objects.checkIndex(index, pages.size());
>>
>> I think we should not replace IOOBE
On Thu, 22 Jul 2021 06:29:13 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>>
>> As Mandy suggested, I create this PR for
On Fri, 30 Jul 2021 08:17:29 GMT, Jayathirth D V wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typo
>
> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1793:
>
>> 1791:
>> 1792: private void
On Thu, 22 Jul 2021 06:29:13 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>>
>> As Mandy suggested, I create this PR for
On Fri, 30 Jul 2021 06:23:40 GMT, Prasanta Sadhukhan
wrote:
>> Hi, sorry for the late response. checkFromToIndex has many constraints, this
>> code may not satisfy those constraints, so I don't think we should do that
>> in this PR.(Maybe we can file a new PR to do replacement carefully)
>
>
On Thu, 22 Jul 2021 06:29:13 GMT, Yi Yang wrote:
>> After JDK-8265518(#3615), it's possible to replace all variants of
>> checkIndex by
>> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
>> the whole JDK codebase.
>>
>> As Mandy suggested, I create this PR for
